Adding docs and completing all validations before returning (#11)

bendbennett · bendbennett · commit d2370581c773 · 2022-06-22T14:44:03.000+01:00
diff --git a/listvalidator/values_are.go b/listvalidator/values_are.go
@@ -46,13 +46,17 @@ func (v valuesAreValidator) Validate(ctx context.Context, req tfsdk.ValidateAttr
 
 		for _, validator := range v.valueValidators {
 			validator.Validate(ctx, request, resp)
-			if resp.Diagnostics.HasError() {
-				return
-			}
 		}
 	}
 }
 
+// ValuesAre returns an AttributeValidator which ensures that any configured
+// attribute value:
+//
+//     - Is a List.
+//     - That contains list elements, each of which validate against each value validator.
+//
+// Null (unconfigured) and unknown (known after apply) values are skipped.
 func ValuesAre(valueValidators ...tfsdk.AttributeValidator) tfsdk.AttributeValidator {
 	return valuesAreValidator{
 		valueValidators: valueValidators,

Original file line number	Diff line number	Diff line change
`@@ -46,13 +46,17 @@ func (v valuesAreValidator) Validate(ctx context.Context, req tfsdk.ValidateAttr`
`46`	`46`
`47`	`47`	`for _, validator := range v.valueValidators {`
`48`	`48`	`validator.Validate(ctx, request, resp)`
`49`		`- if resp.Diagnostics.HasError() {`
`50`		`- return`
`51`		`- }`
`52`	`49`	`}`
`53`	`50`	`}`
`54`	`51`	`}`
`55`	`52`
	`53`	`+// ValuesAre returns an AttributeValidator which ensures that any configured`
	`54`	`+// attribute value:`
	`55`	`+//`
	`56`	`+// - Is a List.`
	`57`	`+// - That contains list elements, each of which validate against each value validator.`
	`58`	`+//`
	`59`	`+// Null (unconfigured) and unknown (known after apply) values are skipped.`
`56`	`60`	`func ValuesAre(valueValidators ...tfsdk.AttributeValidator) tfsdk.AttributeValidator {`
`57`	`61`	`return valuesAreValidator{`
`58`	`62`	`valueValidators: valueValidators,`