Adding Map validation for SizeBetween (#6)

Author: bendbennett

mapvalidator/size_between.go

@@ -0,0 +1,54 @@
+package mapvalidator
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/hashicorp/terraform-plugin-framework/tfsdk"
+
+	"github.com/hashicorp/terraform-plugin-framework-validators/validatordiag"
+)
+
+var _ tfsdk.AttributeValidator = sizeBetweenValidator{}
+
+// sizeBetweenValidator validates that map contains at least min elements
+// and at most max elements.
+type sizeBetweenValidator struct {
+	min int
+	max int
+}
+
+// Description describes the validation in plain text formatting.
+func (v sizeBetweenValidator) Description(ctx context.Context) string {
+	return fmt.Sprintf("map must contain at least %d elements and at most %d elements", v.min, v.max)
+}
+
+// MarkdownDescription describes the validation in Markdown formatting.
+func (v sizeBetweenValidator) MarkdownDescription(ctx context.Context) string {
+	return v.Description(ctx)
+}
+
+// Validate performs the validation.
+func (v sizeBetweenValidator) Validate(ctx context.Context, req tfsdk.ValidateAttributeRequest, resp *tfsdk.ValidateAttributeResponse) {
+	elems, ok := validateMap(ctx, req, resp)
+	if !ok {
+		return
+	}
+
+	if len(elems) < v.min || len(elems) > v.max {
+		resp.Diagnostics.Append(validatordiag.AttributeValueDiagnostic(
+			req.AttributePath,
+			v.Description(ctx),
+			fmt.Sprintf("%d", len(elems)),
+		))
+
+		return
+	}
+}
+
+func SizeBetween(min, max int) tfsdk.AttributeValidator {
+	return sizeBetweenValidator{
+		min: min,
+		max: max,
+	}
+}

mapvalidator/size_between_test.go

@@ -0,0 +1,133 @@
+package mapvalidator
+
+import (
+	"context"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-framework/attr"
+	"github.com/hashicorp/terraform-plugin-framework/tfsdk"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+	"github.com/hashicorp/terraform-plugin-go/tftypes"
+)
+
+func TestSizeBetweenValidator(t *testing.T) {
+	t.Parallel()
+
+	type testCase struct {
+		val         attr.Value
+		min         int
+		max         int
+		expectError bool
+	}
+	tests := map[string]testCase{
+		"not a Map": {
+			val:         types.Bool{Value: true},
+			expectError: true,
+		},
+		"Map unknown": {
+			val: types.Map{
+				Unknown:  true,
+				ElemType: types.StringType,
+			},
+			expectError: false,
+		},
+		"Map null": {
+			val: types.Map{
+				Null:     true,
+				ElemType: types.StringType,
+			},
+			expectError: false,
+		},
+		"Map size greater than min": {
+			val: types.Map{
+				ElemType: types.StringType,
+				Elems: map[string]attr.Value{
+					"one": types.String{Value: "first"},
+					"two": types.String{Value: "second"},
+				},
+			},
+			min:         1,
+			max:         3,
+			expectError: false,
+		},
+		"Map size equal to min": {
+			val: types.Map{
+				ElemType: types.StringType,
+				Elems: map[string]attr.Value{
+					"one": types.String{Value: "first"},
+				},
+			},
+			min:         1,
+			max:         3,
+			expectError: false,
+		},
+		"Map size less than max": {
+			val: types.Map{
+				ElemType: types.StringType,
+				Elems: map[string]attr.Value{
+					"one": types.String{Value: "first"},
+					"two": types.String{Value: "second"},
+				},
+			},
+			min:         1,
+			max:         3,
+			expectError: false,
+		},
+		"Map size equal to max": {
+			val: types.Map{
+				ElemType: types.StringType,
+				Elems: map[string]attr.Value{
+					"one":   types.String{Value: "first"},
+					"two":   types.String{Value: "second"},
+					"three": types.String{Value: "third"},
+				},
+			},
+			min:         1,
+			max:         3,
+			expectError: false,
+		},
+		"Map size less than min": {
+			val: types.Map{
+				ElemType: types.StringType,
+				Elems:    map[string]attr.Value{},
+			},
+			min:         1,
+			max:         3,
+			expectError: true,
+		},
+		"Map size greater than max": {
+			val: types.Map{
+				ElemType: types.StringType,
+				Elems: map[string]attr.Value{
+					"one":   types.String{Value: "first"},
+					"two":   types.String{Value: "second"},
+					"three": types.String{Value: "third"},
+					"four":  types.String{Value: "fourth"},
+				},
+			},
+			min:         1,
+			max:         3,
+			expectError: true,
+		},
+	}
+
+	for name, test := range tests {
+		name, test := name, test
+		t.Run(name, func(t *testing.T) {
+			request := tfsdk.ValidateAttributeRequest{
+				AttributePath:   tftypes.NewAttributePath().WithAttributeName("test"),
+				AttributeConfig: test.val,
+			}
+			response := tfsdk.ValidateAttributeResponse{}
+			SizeBetween(test.min, test.max).Validate(context.TODO(), request, &response)
+
+			if !response.Diagnostics.HasError() && test.expectError {
+				t.Fatal("expected error, got no error")
+			}
+
+			if response.Diagnostics.HasError() && !test.expectError {
+				t.Fatalf("got unexpected error: %s", response.Diagnostics)
+			}
+		})
+	}
+}