Skip to content

Commit cfb1d56

Browse files
committed
change build command and refactor scripts
* Refactors npm scripts. * Changes build command to prods * Fixes production build * Upgrades angular-cli due to: angular/angular-cli#7113 * Adds bugs and repo to package.json
1 parent d739a6a commit cfb1d56

File tree

5 files changed

+22
-9
lines changed

5 files changed

+22
-9
lines changed

.travis.yml

+6
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,17 @@ addons:
1212
- google-chrome
1313
packages:
1414
- google-chrome-stable
15+
16+
before_script:
17+
- npm run lint
18+
- npm run build
19+
1520
before_install:
1621
- npm install buffer-shims
1722
- export CHROME_BIN=chromium-browser
1823
- export DISPLAY=:99.0
1924
- sh -e /etc/init.d/xvfb start
25+
2026
before_deploy: npm run build
2127
deploy:
2228
provider: npm

package.json

+11-5
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@
44
"license": "MIT",
55
"scripts": {
66
"ng": "ng",
7-
"start": "npm run build && npm run serve",
8-
"serve": "ng serve",
9-
"build": "npm run lint && ng build",
10-
"test": "npm run build && ng test --watch=false",
7+
"start": "ng serve",
8+
"build": "ng build --prod --output-hashing none",
9+
"test": "ng test --watch=false",
1110
"test-dev": "ng test",
1211
"lint": "tslint \"src/**/*.ts\"",
1312
"e2e": "ng e2e",
@@ -38,7 +37,7 @@
3837
"zone.js": "^0.8.4"
3938
},
4039
"devDependencies": {
41-
"@angular/cli": "1.0.0",
40+
"@angular/cli": "1.2.6",
4241
"@angular/compiler-cli": "^4.0.0",
4342
"@types/diff": "^3.2.0",
4443
"@types/jasmine": "2.5.38",
@@ -57,5 +56,12 @@
5756
"ts-node": "~2.0.0",
5857
"tslint": "~4.5.0",
5958
"typescript": "~2.2.0"
59+
},
60+
"repository": {
61+
"type": "git",
62+
"url": "https://github.com/inspirehep/ng2-multi-record-editor.git"
63+
},
64+
"bugs": {
65+
"url": "https://github.com/inspirehep/ng2-multi-record-editor/issues"
6066
}
6167
}

src/app/conditions/conditions.component.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<div class="form-group">
1616
<input type="text" name="value" [(ngModel)]="condition.value" class="form-control input-sm" placeholder="condition value">
1717
</div>
18-
<div *ngIf="canDelete" class="form-group">
19-
<i class="fa fa-times" (click)="deleteElement()" aria-hidden="true"></i>
18+
<div class="form-group">
19+
<i class="fa fa-times" aria-hidden="true"></i>
2020
</div>
2121
</form>

src/app/conditions/conditions.component.ts

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { AppGlobalsService } from '../shared/services';
99
})
1010
export class ConditionsComponent {
1111
@Input() condition: Condition;
12+
1213
constructor(private appGlobalsService: AppGlobalsService) { }
1314

1415
get matchTypes(): string[] {

src/app/multi-editor/multi-editor.component.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<me-editor-toolbar-container (onSearchRecordClick)="searchRecords(query)" (onCollectionChange)="onCollectionChange($event)"></me-editor-toolbar-container>
1+
<me-editor-toolbar-container (onCollectionChange)="onCollectionChange($event)"></me-editor-toolbar-container>
22
<div class="container me-container">
33
<me-actions></me-actions>
44
<div class="me-bar">
@@ -20,7 +20,7 @@ <h3>Sorry no results found</h3>
2020
<div class="preview-border">
2121
<button class="btn-success button" (click)="onPreviewClick()">Preview</button>
2222
</div>
23-
<div class="row ">
23+
<div class="row">
2424
<div class="col-md-2">
2525
<span>
2626
<input class="results-checkbox" type="checkbox" [checked]="checkedRecords.length === 0" (change)="selectAll()"> Select all results

0 commit comments

Comments
 (0)