Fix sparse() behavior after item conversion

Fixes #909

Author: Marsup

lib/array.js

@@ -70,6 +70,8 @@ internals.Array.prototype._base = function (value, state, options) {
 
     if (this._inner.inclusions.length ||
         this._inner.exclusions.length ||
+        this._inner.requireds.length ||
+        this._inner.ordereds.length ||
         !this._flags.sparse) {
 
         // Clone the array so that we don't modify the original
@@ -122,7 +124,7 @@ internals.checkItems = function (items, wasArray, state, options) {
         // Sparse
 
         if (!this._flags.sparse && item === undefined) {
-            errors.push(this.createError('array.sparse', null, { key: state.key, path: localState.path }, options));
+            errors.push(this.createError('array.sparse', null, { key: state.key, path: localState.path, pos: i }, options));
 
             if (options.abortEarly) {
                 return errors;
@@ -163,6 +165,15 @@ internals.checkItems = function (items, wasArray, state, options) {
                         --i;
                         --il;
                     }
+                    else if (!this._flags.sparse && res.value === undefined) {
+                        errors.push(this.createError('array.sparse', null, { key: state.key, path: localState.path, pos: i }, options));
+
+                        if (options.abortEarly) {
+                            return errors;
+                        }
+
+                        continue;
+                    }
                     else {
                         items[i] = res.value;
                     }
@@ -196,6 +207,15 @@ internals.checkItems = function (items, wasArray, state, options) {
                 internals.fastSplice(requireds, j);
                 --j;
                 --jl;
+
+                if (!this._flags.sparse && res.value === undefined) {
+                    errors.push(this.createError('array.sparse', null, { key: state.key, path: localState.path, pos: i }, options));
+
+                    if (options.abortEarly) {
+                        return errors;
+                    }
+                }
+
                 break;
             }
         }
@@ -228,6 +248,10 @@ internals.checkItems = function (items, wasArray, state, options) {
                         --i;
                         --il;
                     }
+                    else if (!this._flags.sparse && res.value === undefined) {
+                        errors.push(this.createError('array.sparse', null, { key: state.key, path: localState.path, pos: i }, options));
+                        errored = true;
+                    }
                     else {
                         items[i] = res.value;
                     }

package.json

@@ -27,6 +27,7 @@
   },
   "scripts": {
     "test": "lab -t 100 -a code -L",
+    "test-debug": "node $NODE_DEBUG_OPTION ./node_modules/.bin/lab -a code",
     "test-cov-html": "lab -r html -o coverage.html -a code",
     "toc": "node generate-readme-toc.js",
     "update-npmignore": "npmignore",

test/array.js

@@ -696,6 +696,60 @@ describe('array', () => {
             ], done);
         });
 
+        it('errors on undefined value after validation', (done) => {
+
+            const schema = Joi.array().items(Joi.object().empty({}));
+
+            Helper.validate(schema, [
+                [[{ a: 1 }, {}, { c: 3 }], false, null, '"value" must not be a sparse array']
+            ], done);
+        });
+
+        it('errors on undefined value after validation with abortEarly false', (done) => {
+
+            const schema = Joi.array().items(Joi.object().empty({})).options({ abortEarly: false });
+
+            Helper.validate(schema, [
+                [[{ a: 1 }, {}, 3], false, null, '"value" must not be a sparse array. "value" at position 2 fails because ["2" must be an object]']
+            ], done);
+        });
+
+        it('errors on undefined value after validation with required', (done) => {
+
+            const schema = Joi.array().items(Joi.object().empty({}).required());
+
+            Helper.validate(schema, [
+                [[{}, { c: 3 }], false, null, '"value" must not be a sparse array']
+            ], done);
+        });
+
+        it('errors on undefined value after validation with required and abortEarly false', (done) => {
+
+            const schema = Joi.array().items(Joi.object().empty({}).required()).options({ abortEarly: false });
+
+            Helper.validate(schema, [
+                [[{}, 3], false, null, '"value" must not be a sparse array. "value" at position 1 fails because ["1" must be an object]']
+            ], done);
+        });
+
+        it('errors on undefined value after validation with ordered', (done) => {
+
+            const schema = Joi.array().ordered(Joi.object().empty({}));
+
+            Helper.validate(schema, [
+                [[{}], false, null, '"value" must not be a sparse array']
+            ], done);
+        });
+
+        it('errors on undefined value after validation with ordered and abortEarly false', (done) => {
+
+            const schema = Joi.array().ordered(Joi.object().empty({}).required()).options({ abortEarly: false });
+
+            Helper.validate(schema, [
+                [[{}, 3], false, null, '"value" must not be a sparse array. "value" at position 1 fails because array must contain at most 1 items']
+            ], done);
+        });
+
         it('validates on undefined value with sparse', (done) => {
 
             const schema = Joi.array().items(Joi.number()).sparse();
@@ -706,6 +760,33 @@ describe('array', () => {
             ], done);
         });
 
+        it('validates on undefined value after validation', (done) => {
+
+            const schema = Joi.array().items(Joi.object().empty({})).sparse();
+
+            Helper.validate(schema, [
+                [[{ a: 1 }, {}, { c: 3 }], true, null, [{ a: 1 }, undefined, { c: 3 }]]
+            ], done);
+        });
+
+        it('validates on undefined value after validation with required', (done) => {
+
+            const schema = Joi.array().items(Joi.object().empty({}).required()).sparse();
+
+            Helper.validate(schema, [
+                [[{ a: 1 }, {}, { c: 3 }], true, null, [{ a: 1 }, undefined, { c: 3 }]]
+            ], done);
+        });
+
+        it('validates on undefined value after validation with ordered', (done) => {
+
+            const schema = Joi.array().ordered(Joi.object().empty({})).sparse();
+
+            Helper.validate(schema, [
+                [[{}], true, null, [undefined]]
+            ], done);
+        });
+
         it('switches the sparse flag', (done) => {
 
             const schema = Joi.array().sparse();