feat(@schematics/update): add registry flag

To allow for people that use NPM proxies or local cache and dont have access
to the registry.npmjs.org

Fix angular/angular-cli#10241

Author: hansl

packages/schematics/update/update/index.ts

@@ -631,7 +631,7 @@ export default function(options: UpdateSchema): Rule {
     return observableFrom([...allDependencies.keys()]).pipe(
       // Grab all package.json from the npm repository. This requires a lot of HTTP calls so we
       // try to parallelize as many as possible.
-      mergeMap(depName => getNpmPackageJson(depName, logger)),
+      mergeMap(depName => getNpmPackageJson(depName, options.registry, logger)),
 
       // Build a map of all dependencies and their packageJson.
       reduce<NpmRepositoryPackageJson, Map<string, NpmRepositoryPackageJson>>(

packages/schematics/update/update/npm.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 import { logging } from '@angular-devkit/core';
-import * as http from 'http';
 import { Observable, ReplaySubject } from 'rxjs';
+import * as url from 'url';
 import { NpmRepositoryPackageJson } from './npm-package-json';
 
 
@@ -17,24 +17,34 @@ const npmPackageJsonCache = new Map<string, Observable<NpmRepositoryPackageJson>
 /**
  * Get the NPM repository's package.json for a package. This is p
  * @param {string} packageName The package name to fetch.
+ * @param {string} registryUrl The NPM Registry URL to use.
  * @param {LoggerApi} logger A logger instance to log debug information.
  * @returns An observable that will put the pacakge.json content.
  * @private
  */
 export function getNpmPackageJson(
   packageName: string,
+  registryUrl: string,
   logger: logging.LoggerApi,
 ): Observable<NpmRepositoryPackageJson> {
-  const url = `http://registry.npmjs.org/${packageName.replace(/\//g, '%2F')}`;
+  let fullUrl = new url.URL(`http://${registryUrl}/${packageName.replace(/\//g, '%2F')}`);
+  try {
+    const registry = new url.URL(registryUrl);
+    registry.pathname = (registry.pathname || '')
+        .replace(/\/?$/, '/' + packageName.replace(/\//g, '%2F'));
+    fullUrl = new url.URL(url.format(registry));
+  } catch (_) {
+  }
+
   logger.debug(
-    `Getting package.json from ${JSON.stringify(packageName)} (url: ${JSON.stringify(url)})...`,
+    `Getting package.json from ${JSON.stringify(packageName)} (url: ${JSON.stringify(fullUrl)})...`,
   );
 
-  let maybeRequest = npmPackageJsonCache.get(url);
+  let maybeRequest = npmPackageJsonCache.get(fullUrl);
   if (!maybeRequest) {
     const subject = new ReplaySubject<NpmRepositoryPackageJson>(1);
 
-    const request = http.request(url, response => {
+    const request = require(fullUrl.protocol.replace(/:$/, '')).request(fullUrl, response => {
       let data = '';
       response.on('data', chunk => data += chunk);
       response.on('end', () => {
@@ -51,7 +61,7 @@ export function getNpmPackageJson(
     request.end();
 
     maybeRequest = subject.asObservable();
-    npmPackageJsonCache.set(url, maybeRequest);
+    npmPackageJsonCache.set(fullUrl, maybeRequest);
   }
 
   return maybeRequest;

packages/schematics/update/update/schema.json

@@ -41,6 +41,19 @@
     "to": {
       "description": "Version up to which to apply migrations. Only available with a single package being updated, and only on migrations only. Requires from to be specified. Default to the installed version detected.",
       "type": "string"
+    },
+    "registry": {
+      "description": "The NPM registry to use. If you have an NPM proxy, you need to use this flag and set it to point to the proxy.",
+      "type": "string",
+      "oneOf": [
+        {
+          "format": "uri"
+        },
+        {
+          "format": "hostname"
+        }
+      ],
+      "default": "http://registry.npmjs.org/"
     }
   }
 }

packages/schematics/update/update/schema.ts

@@ -13,4 +13,5 @@ export interface UpdateSchema {
   migrateOnly: boolean;
   from?: string;
   to?: string;
+  registry: string;
 }