WIP: More skips

Author: h-vetinari

pandas/io/excel.py

@@ -396,6 +396,7 @@ def __init__(self, io, **kwds):
         should_close = True
         if _is_url(self._io):
             io = _urlopen(self._io)
+            should_close = True
         elif not isinstance(self.io, (ExcelFile, xlrd.Book)):
             io, _, _, should_close = get_filepath_or_buffer(self._io)
 

pandas/tests/io/parser/c_parser_only.py

@@ -38,6 +38,8 @@ def test_buffer_overflow(self, malf):
         with pytest.raises(pd.errors.ParserError, match=cperr):
             self.read_table(StringIO(malf))
 
+    @pytest.mark.skip('trying to find unclosed socket causing that is '
+                      'causing a Resourcewarning')
     def test_buffer_rd_bytes(self):
         # see gh-12098: src->buffer in the C parser can be freed twice leading
         # to a segfault if a corrupt gzip file is read with 'read_csv' and the
@@ -50,8 +52,6 @@ def test_buffer_rd_bytes(self):
                '\x1f\x8b\x08\x00VT\x97V\x00\x03\xed]\xefO'
         for i in range(100):
             try:
-                pytest.skip('trying to find unclosed socket causing that is '
-                            'causing a Resourcewarning')
                 self.read_csv(StringIO(data),
                               compression='gzip',
                               delim_whitespace=True)

pandas/tests/io/parser/compression.py

@@ -77,6 +77,9 @@ def test_zip(self):
                      marks=td.skip_if_no_lzma)
     ])
     def test_other_compression(self, compress_type, compress_method, ext):
+        if compress_type == 'gzip':
+            pytest.skip('trying to find unclosed socket causing that is '
+                        'causing a Resourcewarning')
 
         with open(self.csv1, 'rb') as data_file:
             data = data_file.read()

pandas/tests/io/parser/python_parser_only.py

@@ -130,6 +130,8 @@ def test_skipfooter(self):
         expected = self.read_csv(StringIO(no_footer))
         tm.assert_frame_equal(result, expected)
 
+    @pytest.mark.skip('trying to find unclosed socket causing that is '
+                      'causing a Resourcewarning')
     def test_decompression_regex_sep(self):
         # see gh-6607
 
@@ -145,8 +147,6 @@ def test_decompression_regex_sep(self):
         expected = self.read_csv(self.csv1)
 
         with tm.ensure_clean() as path:
-            pytest.skip('trying to find unclosed socket causing that is '
-                        'causing a Resourcewarning')
             tmp = gzip.GzipFile(path, mode='wb')
             tmp.write(data)
             tmp.close()

pandas/tests/io/test_excel.py

@@ -681,6 +681,8 @@ def test_read_from_http_url(self, ext):
         local_table = self.get_exceldf('test1', ext)
         tm.assert_frame_equal(url_table, local_table)
 
+    @pytest.mark.skip('trying to find unclosed socket causing that is '
+                      'causing a Resourcewarning')
     @td.skip_if_no("s3fs")
     @td.skip_if_not_us_locale
     def test_read_from_s3_url(self, ext):