Review (jreback)

Author: h-vetinari

doc/source/whatsnew/v0.25.0.rst

@@ -21,7 +21,7 @@ Other Enhancements
 
 - :meth:`Timestamp.replace` now supports the ``fold`` argument to disambiguate DST transition times (:issue:`25017`)
 - :meth:`DataFrame.at_time` and :meth:`Series.at_time` now support :meth:`datetime.time` objects with timezones (:issue:`24043`)
-- :meth:`DataFrame.set_index` now works for instances of ``abc.Iterator``, provided their output is of the same length as the calling frame (:issue:`22484`)
+- :meth:`DataFrame.set_index` now works for instances of ``abc.Iterator``, provided their output is of the same length as the calling frame (:issue:`22484`, :issue:`24984`)
 -
 
 .. _whatsnew_0250.api_breaking:

pandas/tests/frame/test_alter_axes.py

@@ -283,6 +283,7 @@ def test_set_index_raise_on_type(self, frame_of_index_cols, box,
     @pytest.mark.parametrize('drop', [True, False])
     def test_set_index_raise_on_len(self, frame_of_index_cols, box, length,
                                     drop, append):
+        # GH 24984
         df = frame_of_index_cols  # has length 5
 
         values = np.random.randint(0, 10, (length,))