Skip to content

Commit 5506926

Browse files
authored
Merge pull request scala-js#3806 from sjrd/drop-old-2.11-versions
Drop support for old 2.11.x versions.
2 parents db8d913 + 6862a07 commit 5506926

File tree

527 files changed

+20
-49010
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

527 files changed

+20
-49010
lines changed

Jenkinsfile

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -420,15 +420,6 @@ allJavaVersions << mainJavaVersion
420420
def mainScalaVersion = "2.12.8"
421421
def mainScalaVersions = ["2.11.12", "2.12.8", "2.13.0"]
422422
def otherScalaVersions = [
423-
"2.11.0",
424-
"2.11.1",
425-
"2.11.2",
426-
"2.11.4",
427-
"2.11.5",
428-
"2.11.6",
429-
"2.11.7",
430-
"2.11.8",
431-
"2.11.11",
432423
"2.11.12",
433424
"2.12.1",
434425
"2.12.2",
@@ -457,7 +448,7 @@ allJavaVersions.each { javaVersion ->
457448
quickMatrix.add([task: "tools-sbtplugin", scala: "2.12.8", java: javaVersion])
458449
quickMatrix.add([task: "tools", scala: "2.11.12", java: javaVersion])
459450
}
460-
quickMatrix.add([task: "partestc", scala: "2.11.0", java: mainJavaVersion])
451+
quickMatrix.add([task: "partestc", scala: "2.12.1", java: mainJavaVersion])
461452
quickMatrix.add([task: "sbtplugin-test", toolsscala: "2.12.8", java: mainJavaVersion])
462453

463454
// The 'full' matrix
@@ -474,10 +465,7 @@ mainScalaVersions.each { scalaVersion ->
474465
fullMatrix.add([task: "partest-fullopt", scala: scalaVersion, java: mainJavaVersion])
475466
}
476467
otherScalaVersions.each { scalaVersion ->
477-
// Partest does not compile on Scala 2.11.4 (see #1215).
478-
if (scalaVersion != "2.11.4") {
479-
fullMatrix.add([task: "partest-fastopt", scala: scalaVersion, java: mainJavaVersion])
480-
}
468+
fullMatrix.add([task: "partest-fastopt", scala: scalaVersion, java: mainJavaVersion])
481469
}
482470

483471
def Matrices = [

ci/checksizes.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ case $FULLVER in
1414
2.13.0)
1515
VER=2.13
1616
;;
17-
2.11.0|2.11.1|2.11.2|2.11.4|2.11.5|2.11.6|2.11.7|2.11.8|2.11.11|2.12.1|2.12.2|2.12.3|2.12.4|2.12.5|2.12.6|2.12.7)
17+
2.12.1|2.12.2|2.12.3|2.12.4|2.12.5|2.12.6|2.12.7)
1818
echo "Ignoring checksizes for Scala $FULLVER"
1919
exit 0
2020
;;

compiler/src/main/scala/org/scalajs/nscplugin/CompatComponent.scala

Lines changed: 4 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -97,38 +97,12 @@ trait CompatComponent {
9797
}
9898

9999
/* global.genBCode.bTypes.initializeCoreBTypes()
100-
*
101-
* This one has a very particular history:
102-
* - in 2.11.{0-1}, genBCode does not have a bTypes member
103-
* - In 2.11.{2-5}, there is genBCode.bTypes, but it has no
104-
* initializeCoreBTypes (it was actually typo'ed as intializeCoreBTypes!)
105-
* - In 2.11.6+, including 2.12, we finally have
106-
* genBCode.bTypes.initializeCoreBTypes
107-
* - Since 2.12, it is mandatory to call that method from GenJSCode.run()
100+
* Early 2.12.x versions require that this method be called from
101+
* GenJSCode.run(), but it disappeared later in the 2.12.x series.
108102
*/
109103

110-
object LowPrioGenBCodeCompat {
111-
object genBCode {
112-
object bTypes {
113-
def initializeCoreBTypes(): Unit = ()
114-
}
115-
}
116-
}
117-
118-
def initializeCoreBTypesCompat(): Unit = {
119-
import LowPrioGenBCodeCompat.genBCode._
120-
121-
{
122-
import genBCode._
123-
124-
import LowPrioGenBCodeCompat.genBCode.bTypes._
125-
126-
{
127-
import bTypes._
128-
129-
initializeCoreBTypes()
130-
}
131-
}
104+
implicit class BTypesCompat(bTypes: genBCode.bTypes.type) {
105+
def initializeCoreBTypes(): Unit = ()
132106
}
133107
}
134108

compiler/src/main/scala/org/scalajs/nscplugin/GenJSCode.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ abstract class GenJSCode[G <: Global with Singleton](val global: G)
233233

234234
override def run(): Unit = {
235235
scalaPrimitives.init()
236-
initializeCoreBTypesCompat()
236+
genBCode.bTypes.initializeCoreBTypes()
237237
jsPrimitives.init()
238238
super.run()
239239
}

compiler/src/test/scala/org/scalajs/nscplugin/test/util/DirectTest.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ abstract class DirectTest {
9595
def compileString(sourceCode: String): Boolean =
9696
compileString(defaultGlobal)(sourceCode)
9797

98-
// Cannot reuse global, otherwise compiler crashes with Scala >= 2.11.5
99-
// on following tests:
98+
// Cannot reuse global, otherwise the compiler crashes on the following tests:
10099
// - org.scalajs.nscplugin.test.JSExportTest
101100
// - org.scalajs.nscplugin.test.JSDynamicLiteralTest
102101
// Filed as #1443

0 commit comments

Comments
 (0)