fix(mypy): fix resolve_truthy_env_var_choice env typing

`env` is actually a required value otherwise strtobool would fail

Author: michaelbrewer

aws_lambda_powertools/event_handler/api_gateway.py

@@ -274,7 +274,7 @@ def __init__(
         self._cors_enabled: bool = cors is not None
         self._cors_methods: Set[str] = {"OPTIONS"}
         self._debug = resolve_truthy_env_var_choice(
-            choice=debug, env=os.getenv(constants.EVENT_HANDLER_DEBUG_ENV, "false")
+            env=os.getenv(constants.EVENT_HANDLER_DEBUG_ENV, "false"), choice=debug
         )
 
     def get(self, rule: str, cors: Optional[bool] = None, compress: bool = False, cache_control: Optional[str] = None):

aws_lambda_powertools/logging/logger.py

@@ -324,7 +324,7 @@ def handler(event, context):
             )
 
         log_event = resolve_truthy_env_var_choice(
-            choice=log_event, env=os.getenv(constants.LOGGER_LOG_EVENT_ENV, "false")
+            env=os.getenv(constants.LOGGER_LOG_EVENT_ENV, "false"), choice=log_event
         )
 
         @functools.wraps(lambda_handler)

aws_lambda_powertools/middleware_factory/factory.py

@@ -106,7 +106,7 @@ def lambda_handler(event, context):
         return functools.partial(lambda_handler_decorator, trace_execution=trace_execution)
 
     trace_execution = resolve_truthy_env_var_choice(
-        choice=trace_execution, env=os.getenv(constants.MIDDLEWARE_FACTORY_TRACE_ENV, "false")
+        env=os.getenv(constants.MIDDLEWARE_FACTORY_TRACE_ENV, "false"), choice=trace_execution
     )
 
     @functools.wraps(decorator)

aws_lambda_powertools/shared/functions.py

@@ -2,14 +2,14 @@
 from typing import Any, Optional, Union
 
 
-def resolve_truthy_env_var_choice(env: Optional[Any] = None, choice: Optional[bool] = None) -> bool:
+def resolve_truthy_env_var_choice(env: str, choice: Optional[bool] = None) -> bool:
     """Pick explicit choice over truthy env value, if available, otherwise return truthy env value
 
     NOTE: Environment variable should be resolved by the caller.
 
     Parameters
     ----------
-    env : Any, Optional
+    env : str
         environment variable actual value
     choice : bool
         explicit choice