refactor(idempotent): remove include_function_name

Author: michaelbrewer

aws_lambda_powertools/utilities/idempotency/config.py

@@ -33,8 +33,6 @@ def __init__(
             Max number of items to store in local cache, by default 1024
         hash_function: str, optional
             Function to use for calculating hashes, by default md5.
-        include_function_name: bool, optional
-            Whether to include the function name in the idempotent key
         """
         self.event_key_jmespath = event_key_jmespath
         self.payload_validation_jmespath = payload_validation_jmespath
@@ -44,4 +42,3 @@ def __init__(
         self.use_local_cache = use_local_cache
         self.local_cache_max_items = local_cache_max_items
         self.hash_function = hash_function
-        self.include_function_name = include_function_name

aws_lambda_powertools/utilities/idempotency/persistence/base.py

@@ -122,7 +122,6 @@ def __init__(self):
         self.use_local_cache = False
         self._cache: Optional[LRUDict] = None
         self.hash_function = None
-        self.include_function_name = True
 
     def configure(self, config: IdempotencyConfig) -> None:
         """
@@ -153,7 +152,6 @@ def configure(self, config: IdempotencyConfig) -> None:
         if self.use_local_cache:
             self._cache = LRUDict(max_items=config.local_cache_max_items)
         self.hash_function = getattr(hashlib, config.hash_function)
-        self.include_function_name = config.include_function_name
 
     def _get_hashed_idempotency_key(self, event: Dict[str, Any], context: LambdaContext) -> str:
         """
@@ -183,10 +181,7 @@ def _get_hashed_idempotency_key(self, event: Dict[str, Any], context: LambdaCont
             warnings.warn(f"No value found for idempotency_key. jmespath: {self.event_key_jmespath}")
 
         generated_hash = self._generate_hash(data)
-        if self.include_function_name:
-            return f"{context.function_name}#{generated_hash}"
-        else:
-            return generated_hash
+        return f"{context.function_name}#{generated_hash}"
 
     @staticmethod
     def is_missing_idempotency_key(data) -> bool:

tests/functional/idempotency/test_idempotency.py

@@ -828,16 +828,3 @@ def lambda_handler(event, context):
     stubber.assert_no_pending_responses()
     stubber.deactivate()
     assert "Failed to save in progress record to idempotency store" == e.value.args[0]
-
-
-def test_include_function_name_false(persistence_store: DynamoDBPersistenceLayer):
-    # GIVEN include_function_name=False
-    persistence_store.configure(IdempotencyConfig(event_key_jmespath="body", include_function_name=False))
-    value = "true"
-    api_gateway_proxy_event = {"body": value}
-
-    # WHEN
-    result = persistence_store._get_hashed_idempotency_key(api_gateway_proxy_event, None)
-
-    # THEN
-    assert result == persistence_store._generate_hash(value)