Skip to content

Commit c1736e3

Browse files
committed
Remove PullDOM support.
The test harness hasn't ever properly had an adapter that matches the behaviour of PullDOM, and I have no interest in fixing this, so let's simply drop support. AFAICT, nobody uses this.
1 parent 6b80bf6 commit c1736e3

File tree

3 files changed

+1
-96
lines changed

3 files changed

+1
-96
lines changed

html5lib/tests/test_treewalkers.py

-31
Original file line numberDiff line numberDiff line change
@@ -16,40 +16,9 @@
1616
from html5lib import html5parser, treewalkers, treebuilders, treeadapters, constants
1717

1818

19-
def PullDOMAdapter(node):
20-
from xml.dom import Node
21-
from xml.dom.pulldom import START_ELEMENT, END_ELEMENT, COMMENT, CHARACTERS
22-
23-
if node.nodeType in (Node.DOCUMENT_NODE, Node.DOCUMENT_FRAGMENT_NODE):
24-
for childNode in node.childNodes:
25-
for event in PullDOMAdapter(childNode):
26-
yield event
27-
28-
elif node.nodeType == Node.DOCUMENT_TYPE_NODE:
29-
raise NotImplementedError("DOCTYPE nodes are not supported by PullDOM")
30-
31-
elif node.nodeType == Node.COMMENT_NODE:
32-
yield COMMENT, node
33-
34-
elif node.nodeType in (Node.TEXT_NODE, Node.CDATA_SECTION_NODE):
35-
yield CHARACTERS, node
36-
37-
elif node.nodeType == Node.ELEMENT_NODE:
38-
yield START_ELEMENT, node
39-
for childNode in node.childNodes:
40-
for event in PullDOMAdapter(childNode):
41-
yield event
42-
yield END_ELEMENT, node
43-
44-
else:
45-
raise NotImplementedError("Node type not supported: " + str(node.nodeType))
46-
4719
treeTypes = {
4820
"DOM": {"builder": treebuilders.getTreeBuilder("dom"),
4921
"walker": treewalkers.getTreeWalker("dom")},
50-
"PullDOM": {"builder": treebuilders.getTreeBuilder("dom"),
51-
"adapter": PullDOMAdapter,
52-
"walker": treewalkers.getTreeWalker("pulldom")},
5322
}
5423

5524
# Try whatever etree implementations are available from a list that are

html5lib/treewalkers/__init__.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010

1111
from __future__ import absolute_import, division, unicode_literals
1212

13-
__all__ = ["getTreeWalker", "pprint", "dom", "etree", "genshistream", "lxmletree",
14-
"pulldom"]
13+
__all__ = ["getTreeWalker", "pprint", "dom", "etree", "genshistream", "lxmletree"]
1514

1615
import sys
1716

html5lib/treewalkers/pulldom.py

-63
This file was deleted.

0 commit comments

Comments
 (0)