Skip to content

Commit 7ec3fd2

Browse files
authored
balancer/rls: Fix RLS Cache metrics (#7511)
1 parent 6d7f07c commit 7ec3fd2

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

balancer/rls/cache.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ type dataCache struct {
180180
}
181181

182182
func newDataCache(size int64, logger *internalgrpclog.PrefixLogger, metricsRecorder estats.MetricsRecorder, grpcTarget string) *dataCache {
183-
dc := &dataCache{
183+
return &dataCache{
184184
maxSize: size,
185185
keys: newLRU(),
186186
entries: make(map[cacheKey]*cacheEntry),
@@ -190,9 +190,6 @@ func newDataCache(size int64, logger *internalgrpclog.PrefixLogger, metricsRecor
190190
uuid: uuid.New().String(),
191191
metricsRecorder: metricsRecorder,
192192
}
193-
cacheSizeMetric.Record(dc.metricsRecorder, 0, grpcTarget, "", dc.uuid)
194-
cacheEntriesMetric.Record(dc.metricsRecorder, 0, grpcTarget, "", dc.uuid)
195-
return dc
196193
}
197194

198195
// updateRLSServerTarget updates the RLS Server Target the RLS Balancer is
@@ -330,6 +327,8 @@ func (dc *dataCache) addEntry(key cacheKey, entry *cacheEntry) (backoffCancelled
330327
if dc.currentSize > dc.maxSize {
331328
backoffCancelled = dc.resize(dc.maxSize)
332329
}
330+
cacheSizeMetric.Record(dc.metricsRecorder, dc.currentSize, dc.grpcTarget, dc.rlsServerTarget, dc.uuid)
331+
cacheEntriesMetric.Record(dc.metricsRecorder, int64(len(dc.entries)), dc.grpcTarget, dc.rlsServerTarget, dc.uuid)
333332
return backoffCancelled, true
334333
}
335334

0 commit comments

Comments
 (0)