transport: Remove redundant if in handleGoAway (#6930)

narqo · web-flow · commit 67e50be52699 · 2024-01-22T19:31:00.000-05:00
diff --git a/internal/transport/http2_client.go b/internal/transport/http2_client.go
@@ -1325,10 +1325,8 @@ func (t *http2Client) handleGoAway(f *http2.GoAwayFrame) {
 	for streamID, stream := range t.activeStreams {
 		if streamID > id && streamID <= upperLimit {
 			// The stream was unprocessed by the server.
-			if streamID > id && streamID <= upperLimit {
-				atomic.StoreUint32(&stream.unprocessed, 1)
-				streamsToClose = append(streamsToClose, stream)
-			}
+			atomic.StoreUint32(&stream.unprocessed, 1)
+			streamsToClose = append(streamsToClose, stream)
 		}
 	}
 	t.mu.Unlock()

Original file line number	Diff line number	Diff line change
`@@ -1325,10 +1325,8 @@ func (t http2Client) handleGoAway(f http2.GoAwayFrame) {`
`1325`	`1325`	`for streamID, stream := range t.activeStreams {`
`1326`	`1326`	`if streamID > id && streamID <= upperLimit {`
`1327`	`1327`	`// The stream was unprocessed by the server.`
`1328`		`- if streamID > id && streamID <= upperLimit {`
`1329`		`- atomic.StoreUint32(&stream.unprocessed, 1)`
`1330`		`- streamsToClose = append(streamsToClose, stream)`
`1331`		`- }`
	`1328`	`+ atomic.StoreUint32(&stream.unprocessed, 1)`
	`1329`	`+ streamsToClose = append(streamsToClose, stream)`
`1332`	`1330`	`}`
`1333`	`1331`	`}`
`1334`	`1332`	`t.mu.Unlock()`