Skip to content

Commit 80f1a6b

Browse files
author
Geert Vanderkelen
committed
Fix assert message in Register class. Fixes #91.
1 parent 136d2b3 commit 80f1a6b

File tree

2 files changed

+32
-1
lines changed

2 files changed

+32
-1
lines changed

graphene_sqlalchemy/registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def __init__(self):
88
def register(self, cls):
99
from .types import SQLAlchemyObjectType
1010
assert issubclass(cls, SQLAlchemyObjectType), (
11-
'Only classes of type SQLAlchemyObjectType can be registered, ',
11+
'Only classes of type SQLAlchemyObjectType can be registered, '
1212
'received "{}"'
1313
).format(cls.__name__)
1414
assert cls._meta.registry == self, 'Registry for a Model have to match.'
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
import pytest
2+
3+
from .models import Pet
4+
from ..registry import Registry
5+
from ..types import SQLAlchemyObjectType
6+
7+
8+
def test_register_incorrect_objecttype():
9+
reg = Registry()
10+
11+
class Spam:
12+
pass
13+
14+
with pytest.raises(AssertionError) as excinfo:
15+
reg.register(Spam)
16+
17+
assert 'Only classes of type SQLAlchemyObjectType can be registered' in str(excinfo.value)
18+
19+
20+
def test_register_objecttype():
21+
reg = Registry()
22+
23+
class PetType(SQLAlchemyObjectType):
24+
class Meta:
25+
model = Pet
26+
registry = reg
27+
28+
try:
29+
reg.register(PetType)
30+
except AssertionError:
31+
pytest.fail("expected no AssertionError")

0 commit comments

Comments
 (0)