From 091d7deb8ae53e3d7d96f437ad22e9b5336b6e9c Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Fri, 24 May 2019 15:15:11 -0700 Subject: [PATCH 1/3] work around aiohttp-cors method star problem --- aiohttp_graphql/graphqlview.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/aiohttp_graphql/graphqlview.py b/aiohttp_graphql/graphqlview.py index 362d87e..fe1b7fd 100644 --- a/aiohttp_graphql/graphqlview.py +++ b/aiohttp_graphql/graphqlview.py @@ -202,4 +202,11 @@ def process_preflight(self, request): def attach(cls, app, *, route_path='/graphql', route_name='graphql', **kwargs): view = cls(**kwargs) - app.router.add_route('*', route_path, view, name=route_name) + #app.router.add_route('*', route_path, view, name=route_name) + app.router.add_route('GET', route_path, view, name=route_name) + app.router.add_route('POST', route_path, view, name=route_name) + app.router.add_route('PUT', route_path, view, name=route_name) + app.router.add_route('DELETE', route_path, view, name=route_name) + app.router.add_route('PATCH', route_path, view, name=route_name) + app.router.add_route('HEAD', route_path, view, name=route_name) + #app.router.add_route('OPTIONS', route_path, view, name=route_name) From 03765fc7f25555c64c74dd7397893ba3acf214ee Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Fri, 31 May 2019 08:41:43 -0700 Subject: [PATCH 2/3] prettier code --- aiohttp_graphql/graphqlview.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/aiohttp_graphql/graphqlview.py b/aiohttp_graphql/graphqlview.py index fe1b7fd..44ccb84 100644 --- a/aiohttp_graphql/graphqlview.py +++ b/aiohttp_graphql/graphqlview.py @@ -203,10 +203,5 @@ def attach(cls, app, *, route_path='/graphql', route_name='graphql', **kwargs): view = cls(**kwargs) #app.router.add_route('*', route_path, view, name=route_name) - app.router.add_route('GET', route_path, view, name=route_name) - app.router.add_route('POST', route_path, view, name=route_name) - app.router.add_route('PUT', route_path, view, name=route_name) - app.router.add_route('DELETE', route_path, view, name=route_name) - app.router.add_route('PATCH', route_path, view, name=route_name) - app.router.add_route('HEAD', route_path, view, name=route_name) - #app.router.add_route('OPTIONS', route_path, view, name=route_name) + for method in ('GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'HEAD'): # no OPTIONS + app.router.add_route(method, route_path, view, name=route_name) From 068b8a219da51fe9d57e00d1cbcfe210f0cd13ac Mon Sep 17 00:00:00 2001 From: Greg Lindahl Date: Tue, 4 Jun 2019 16:31:11 -0700 Subject: [PATCH 3/3] graphiql for .attach --- aiohttp_graphql/graphqlview.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/aiohttp_graphql/graphqlview.py b/aiohttp_graphql/graphqlview.py index 44ccb84..f176261 100644 --- a/aiohttp_graphql/graphqlview.py +++ b/aiohttp_graphql/graphqlview.py @@ -205,3 +205,8 @@ def attach(cls, app, *, route_path='/graphql', route_name='graphql', #app.router.add_route('*', route_path, view, name=route_name) for method in ('GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'HEAD'): # no OPTIONS app.router.add_route(method, route_path, view, name=route_name) + + # apparently this is just plain missing otherwise? + if 'graphiql' in kwargs and kwargs['graphiql']: + for method in ('GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'HEAD'): # no OPTIONS + app.router.add_route(method, '/graphiql', view, name='graphiql')