fixed failing tests, silenced deprecationwarnings

Signed-off-by: Oleg Höfling <[email protected]>

Author: hoefling

aiohttp_graphql/graphqlview.py

@@ -202,4 +202,15 @@ def process_preflight(self, request):
     def attach(cls, app, *, route_path='/graphql', route_name='graphql',
                **kwargs):
         view = cls(**kwargs)
-        app.router.add_route('*', route_path, view, name=route_name)
+        app.router.add_route('*', route_path, _asyncify(view), name=route_name)
+
+
+def _asyncify(handler):
+    """
+    This is mainly here because ``aiohttp`` can't infer the async definition of
+    :py:meth:`.GraphQLView.__call__` and raises a :py:class:`DeprecationWarning`
+    in tests. Wrapping it into an async function avoids the noisy warning.
+    """
+    async def _dispatch(request):
+        return await handler(request)
+    return _dispatch

setup.cfg

@@ -10,3 +10,5 @@ norecursedirs =
   .git
   .tox
 testpaths = tests/
+filterwarnings =
+  ignore:(context|root)_value has been deprecated.*:DeprecationWarning:graphql.backend.core:32

tests/conftest.py

@@ -26,15 +26,15 @@ def view_kwargs():
 
 # aiohttp Fixtures
 @pytest.fixture
-def app(event_loop, executor, view_kwargs):
-    app = web.Application(loop=event_loop)
+def app(executor, view_kwargs):
+    app = web.Application()
     GraphQLView.attach(app, executor=executor, **view_kwargs)
     return app
 
 
 @pytest.fixture
 async def client(event_loop, app):
-    client = aiohttp.test_utils.TestClient(app, loop=event_loop)
+    client = aiohttp.test_utils.TestClient(aiohttp.test_utils.TestServer(app), loop=event_loop)
     await client.start_server()
     yield client
     await client.close()

tests/test_graphqlview.py

@@ -432,7 +432,7 @@ async def test_handles_field_errors_caught_by_graphql(client, url_builder):
     assert await response.json() == {
         'data': None,
         'errors': [
-            {'locations': [{'column': 2, 'line': 1}], 'message': 'Throws!'},
+            {'locations': [{'column': 2, 'line': 1}], 'message': 'Throws!', 'path': ['thrower']},
         ],
     }
 
@@ -447,8 +447,7 @@ async def test_handles_syntax_errors_caught_by_graphql(client, url_builder):
             {
                 'locations': [{'column': 1, 'line': 1}],
                 'message': (
-                    'Syntax Error GraphQL request (1:1) '
-                    'Unexpected Name "syntaxerror"\n\n1: syntaxerror\n   ^\n'
+                    'Syntax Error GraphQL (1:1) Unexpected Name "syntaxerror"\n\n1: syntaxerror\n   ^\n'
                 ),
             },
         ],