Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Commit f008f66

Browse files
committed
fix: remove field bean autowiring in favor of constructor injection
1 parent 8b1e539 commit f008f66

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

graphql-spring-boot-autoconfigure/src/main/java/graphql/kickstart/autoconfigure/tools/ClasspathResourceSchemaStringProvider.java

+5-6
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,18 @@
1010
import java.util.Arrays;
1111
import java.util.List;
1212
import java.util.stream.Collectors;
13-
import org.springframework.beans.factory.annotation.Autowired;
13+
import lombok.AllArgsConstructor;
14+
import lombok.extern.slf4j.Slf4j;
1415
import org.springframework.context.ApplicationContext;
1516
import org.springframework.core.io.Resource;
1617

18+
@Slf4j
19+
@AllArgsConstructor
1720
public class ClasspathResourceSchemaStringProvider implements SchemaStringProvider {
1821

19-
@Autowired private ApplicationContext applicationContext;
22+
private ApplicationContext applicationContext;
2023
private String schemaLocationPattern;
2124

22-
public ClasspathResourceSchemaStringProvider(String schemaLocationPattern) {
23-
this.schemaLocationPattern = schemaLocationPattern;
24-
}
25-
2625
@Override
2726
public List<String> schemaStrings() throws IOException {
2827
Resource[] resources = applicationContext.getResources("classpath*:" + schemaLocationPattern);

graphql-spring-boot-autoconfigure/src/main/java/graphql/kickstart/autoconfigure/tools/GraphQLJavaToolsAutoConfiguration.java

+9-2
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.springframework.boot.autoconfigure.jackson.JacksonAutoConfiguration;
3737
import org.springframework.boot.context.properties.ConfigurationProperties;
3838
import org.springframework.boot.context.properties.EnableConfigurationProperties;
39+
import org.springframework.context.ApplicationContext;
3940
import org.springframework.context.annotation.Bean;
4041

4142
/** @author Andrew Potter */
@@ -52,8 +53,14 @@ public class GraphQLJavaToolsAutoConfiguration {
5253

5354
@Bean
5455
@ConditionalOnMissingBean
55-
public SchemaStringProvider schemaStringProvider(GraphQLToolsProperties props) {
56-
return new ClasspathResourceSchemaStringProvider(props.getSchemaLocationPattern());
56+
public SchemaStringProvider schemaStringProvider(
57+
ApplicationContext applicationContext,
58+
GraphQLToolsProperties props
59+
) {
60+
return new ClasspathResourceSchemaStringProvider(
61+
applicationContext,
62+
props.getSchemaLocationPattern()
63+
);
5764
}
5865

5966
@Bean

0 commit comments

Comments
 (0)