Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Commit 7ab48d2

Browse files
authored
Merge branch 'graphql-java-kickstart:master' into add-ability-to-pass-strings-to-graphqltesttemplate
2 parents 64b78d6 + c99e7f3 commit 7ab48d2

File tree

7 files changed

+186
-167
lines changed

7 files changed

+186
-167
lines changed

commitlint/package-lock.json

Lines changed: 169 additions & 152 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

commitlint/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"author": "",
1010
"license": "MIT",
1111
"devDependencies": {
12-
"@commitlint/cli": "16.2.3",
13-
"@commitlint/config-conventional": "16.2.1",
14-
"husky": "7.0.4"
12+
"@commitlint/cli": "17.0.2",
13+
"@commitlint/config-conventional": "17.0.2",
14+
"husky": "8.0.1"
1515
}
1616
}

gradle.properties

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,18 @@ VCS=Git
2929
SOURCE_COMPATIBILITY=1.8
3030
TARGET_COMPATIBILITY=1.8
3131
### Dependencies
32-
LIB_GRAPHQL_JAVA_VER=18.0
33-
LIB_EXTENDED_SCALARS_VER=17.0
34-
LIB_SPRING_BOOT_VER=2.6.6
32+
LIB_GRAPHQL_JAVA_VER=18.1
33+
LIB_EXTENDED_SCALARS_VER=18.1
34+
LIB_SPRING_BOOT_VER=2.7.0
3535
LIB_GRAPHQL_SERVLET_VER=13.0.0-SNAPSHOT
36-
LIB_GRAPHQL_JAVA_TOOLS_VER=12.0.2
36+
LIB_GRAPHQL_JAVA_TOOLS_VER=12.1.0
3737
LIB_GRAPHQL_ANNOTATIONS_VER=9.1
3838
LIB_REFLECTIONS_VER=0.10.2
3939
LIB_APACHE_COMMONS_TEXT_VER=1.9
4040
LIB_AWAITILITY_VER=4.2.0
41-
LIB_JSOUP_VER=1.14.3
41+
LIB_JSOUP_VER=1.15.1
4242
### Plugins
4343
PLUGIN_JACOCO_VER=0.8.7
44-
PLUGIN_SONARQUBE_VER=3.3
44+
PLUGIN_SONARQUBE_VER=3.4.0.2513
4545
PLUGIN_NEXUS_STAGING_VER=0.30.0
4646
PLUGIN_GOOGLE_JAVA_FORMAT_VER=0.9

graphql-spring-boot-autoconfigure/src/main/java/graphql/kickstart/autoconfigure/editor/graphiql/GraphiQLController.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import java.util.HashMap;
1616
import java.util.Map;
1717
import java.util.Optional;
18+
import java.util.regex.Pattern;
1819
import lombok.RequiredArgsConstructor;
1920
import lombok.extern.slf4j.Slf4j;
2021
import org.apache.commons.lang3.StringUtils;
@@ -195,7 +196,7 @@ private String constructGraphQlEndpoint(
195196
String contextPath, @RequestParam Map<String, String> params) {
196197
String endpoint = graphiQLProperties.getEndpoint().getGraphql();
197198
for (Map.Entry<String, String> param : params.entrySet()) {
198-
endpoint = endpoint.replaceAll("\\{" + param.getKey() + "}", param.getValue());
199+
endpoint = endpoint.replaceAll("\\{" + Pattern.quote(param.getKey()) + "}", param.getValue());
199200
}
200201
if (StringUtils.isNotBlank(contextPath) && !endpoint.startsWith(contextPath)) {
201202
return contextPath + endpoint;

graphql-spring-boot-autoconfigure/src/main/java/graphql/kickstart/autoconfigure/editor/voyager/VoyagerIndexHtmlTemplate.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import java.nio.charset.Charset;
88
import java.util.HashMap;
99
import java.util.Map;
10+
import java.util.regex.Pattern;
1011
import lombok.RequiredArgsConstructor;
1112
import org.apache.commons.lang3.StringUtils;
1213
import org.apache.commons.text.StringSubstitutor;
@@ -112,7 +113,7 @@ private String constructGraphQlEndpoint(
112113
String contextPath, @RequestParam Map<String, String> params) {
113114
String endpoint = voyagerConfiguration.getEndpoint();
114115
for (Map.Entry<String, String> param : params.entrySet()) {
115-
endpoint = endpoint.replaceAll("\\{" + param.getKey() + "}", param.getValue());
116+
endpoint = endpoint.replaceAll("\\{" + Pattern.quote(param.getKey()) + "}", param.getValue());
116117
}
117118
if (StringUtils.isNotBlank(contextPath) && !endpoint.startsWith(contextPath)) {
118119
return contextPath + endpoint;

graphql-spring-boot-autoconfigure/src/test/java/graphql/kickstart/autoconfigure/web/servlet/test/aliasedscalars/AliasedScalarsIncorrectConfigurationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ void shouldThrowErrorOnStartupIfScalarDoesNotExists() {
3434
"Scalar(s) 'BugDecimal' cannot be aliased."
3535
+ " Only the following scalars can be aliased by configuration: BigDecimal,"
3636
+ " BigInteger, Boolean, Byte, Char, Date, DateTime, Float, ID, Int, JSON,"
37-
+ " Locale, Long, NegativeFloat, NegativeInt, NonNegativeFloat, NonNegativeInt,"
37+
+ " LocalTime, Locale, Long, NegativeFloat, NegativeInt, NonNegativeFloat, NonNegativeInt,"
3838
+ " NonPositiveFloat, NonPositiveInt, Object, PositiveFloat, PositiveInt, Short,"
39-
+ " String, Time, Url. Note that custom scalar beans cannot be aliased this way.");
39+
+ " String, Time, UUID, Url. Note that custom scalar beans cannot be aliased this way.");
4040
}
4141

4242
@Test

graphql-spring-boot-autoconfigure/src/test/java/graphql/kickstart/autoconfigure/web/servlet/test/extendedscalars/ExtendedScalarsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ void shouldThrowErrorOnStartupIfExtendedScalarDoesNotExists() {
3131
.isThrownBy(application::run)
3232
.withMessage(
3333
"Invalid extended scalar name(s) found: BadDecimal, Datee. Valid names are: BigDecimal, "
34-
+ "BigInteger, Byte, Char, Date, DateTime, JSON, Locale, Long, NegativeFloat, NegativeInt, "
34+
+ "BigInteger, Byte, Char, Date, DateTime, JSON, LocalTime, Locale, Long, NegativeFloat, NegativeInt, "
3535
+ "NonNegativeFloat, NonNegativeInt, NonPositiveFloat, NonPositiveInt, Object, PositiveFloat, "
36-
+ "PositiveInt, Short, Time, Url.");
36+
+ "PositiveInt, Short, Time, UUID, Url.");
3737
}
3838

3939
@Test

0 commit comments

Comments
 (0)