fix(Angular): remove angular.lowercase and angular.uppercase

Narretz · web-flow · commit 1daa4f2231a8 · 2017-03-08T14:33:34.000+01:00
Closes angular#15445 BREAKING CHANGE: The helper functions `angular.lowercase` `and angular.uppercase` have been removed. These functions have been deprecated since 1.5.0. They are internally used, but should not be exposed as they contain special locale handling (for Turkish) to maintain internal consistency regardless of user-set locale. Developers should generally use the built-ins `toLowerCase` and `toUpperCase` or `toLocaleLowerCase` and `toLocaleUpperCase` for special cases. Further, we generally discourage using the angular.x helpers in application code.
diff --git a/src/Angular.js b/src/Angular.js
@@ -173,15 +173,7 @@ function isValidObjectMaxDepth(maxDepth) {
 }
 
 /**
- * @ngdoc function
- * @name angular.lowercase
- * @module ng
- * @kind function
- *
- * @deprecated
- * sinceVersion="1.5.0"
- * removeVersion="1.7.0"
- * Use [String.prototype.toLowerCase](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String/toLowerCase) instead.
+ * @private
  *
  * @description Converts the specified string to lowercase.
  * @param {string} string String to be converted to lowercase.
@@ -190,15 +182,7 @@ function isValidObjectMaxDepth(maxDepth) {
 var lowercase = function(string) {return isString(string) ? string.toLowerCase() : string;};
 
 /**
- * @ngdoc function
- * @name angular.uppercase
- * @module ng
- * @kind function
- *
- * @deprecated
- * sinceVersion="1.5.0"
- * removeVersion="1.7.0"
- * Use [String.prototype.toUpperCase](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase) instead.
+ * @private
  *
  * @description Converts the specified string to uppercase.
  * @param {string} string String to be converted to uppercase.
diff --git a/src/AngularPublic.js b/src/AngularPublic.js
@@ -150,16 +150,16 @@ function publishExternalAPI(angular) {
     'isArray': isArray,
     'version': version,
     'isDate': isDate,
-    'lowercase': lowercase,
-    'uppercase': uppercase,
     'callbacks': {$$counter: 0},
     'getTestability': getTestability,
     'reloadWithDebugInfo': reloadWithDebugInfo,
     '$$minErr': minErr,
     '$$csp': csp,
     '$$encodeUriSegment': encodeUriSegment,
     '$$encodeUriQuery': encodeUriQuery,
-    '$$stringify': stringify
+    '$$lowercase': lowercase,
+    '$$stringify': stringify,
+    '$$uppercase': uppercase
   });
 
   angularModule = setupModuleLoader(window);
diff --git a/src/ngMock/angular-mocks.js b/src/ngMock/angular-mocks.js
@@ -2073,13 +2073,13 @@ function MockXhr() {
     var header = this.$$respHeaders[name];
     if (header) return header;
 
-    name = angular.lowercase(name);
+    name = angular.$$lowercase(name);
     header = this.$$respHeaders[name];
     if (header) return header;
 
     header = undefined;
     angular.forEach(this.$$respHeaders, function(headerVal, headerName) {
-      if (!header && angular.lowercase(headerName) === name) header = headerVal;
+      if (!header && angular.$$lowercase(headerName) === name) header = headerVal;
     });
     return header;
   };
diff --git a/src/ngSanitize/sanitize.js b/src/ngSanitize/sanitize.js
@@ -213,7 +213,7 @@ function $SanitizeProvider() {
   extend = angular.extend;
   forEach = angular.forEach;
   isDefined = angular.isDefined;
-  lowercase = angular.lowercase;
+  lowercase = angular.$$lowercase;
   noop = angular.noop;
 
   htmlParser = htmlParserImpl;
diff --git a/src/ngTouch/touch.js b/src/ngTouch/touch.js
@@ -29,7 +29,7 @@ ngTouch.info({ angularVersion: '"NG_VERSION_FULL"' });
 ngTouch.provider('$touch', $TouchProvider);
 
 function nodeName_(element) {
-  return angular.lowercase(element.nodeName || (element[0] && element[0].nodeName));
+  return angular.$$lowercase(element.nodeName || (element[0] && element[0].nodeName));
 }
 
 /**
diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js
@@ -11388,7 +11388,7 @@ describe('$compile', function() {
         element = $compile('<iframe srcdoc="{{html}}"></iframe>')($rootScope);
         $rootScope.html = $sce.trustAsHtml('<div onclick="">hello</div>');
         $rootScope.$digest();
-        expect(angular.lowercase(element.attr('srcdoc'))).toEqual('<div onclick="">hello</div>');
+        expect(lowercase(element.attr('srcdoc'))).toEqual('<div onclick="">hello</div>');
       }));
     });
   }
diff --git a/test/ng/directive/ngBindSpec.js b/test/ng/directive/ngBindSpec.js
@@ -176,17 +176,17 @@ describe('ngBind*', function() {
         element = $compile('<div ng-bind-html="html"></div>')($rootScope);
         $rootScope.html = '<div onclick="">hello</div>';
         $rootScope.$digest();
-        expect(angular.lowercase(element.html())).toEqual('<div onclick="">hello</div>');
+        expect(lowercase(element.html())).toEqual('<div onclick="">hello</div>');
       }));
 
       it('should update html', inject(function($rootScope, $compile, $sce) {
         element = $compile('<div ng-bind-html="html"></div>')($rootScope);
         $rootScope.html = 'hello';
         $rootScope.$digest();
-        expect(angular.lowercase(element.html())).toEqual('hello');
+        expect(lowercase(element.html())).toEqual('hello');
         $rootScope.html = 'goodbye';
         $rootScope.$digest();
-        expect(angular.lowercase(element.html())).toEqual('goodbye');
+        expect(lowercase(element.html())).toEqual('goodbye');
       }));
 
       it('should one-time bind if the expression starts with two colons', inject(function($rootScope, $compile) {
@@ -220,17 +220,17 @@ describe('ngBind*', function() {
         element = $compile('<div ng-bind-html="html"></div>')($rootScope);
         $rootScope.html = $sce.trustAsHtml('<div onclick="">hello</div>');
         $rootScope.$digest();
-        expect(angular.lowercase(element.html())).toEqual('<div onclick="">hello</div>');
+        expect(lowercase(element.html())).toEqual('<div onclick="">hello</div>');
       }));
 
       it('should update html', inject(function($rootScope, $compile, $sce) {
         element = $compile('<div ng-bind-html="html"></div>')($rootScope);
         $rootScope.html = $sce.trustAsHtml('hello');
         $rootScope.$digest();
-        expect(angular.lowercase(element.html())).toEqual('hello');
+        expect(lowercase(element.html())).toEqual('hello');
         $rootScope.html = $sce.trustAsHtml('goodbye');
         $rootScope.$digest();
-        expect(angular.lowercase(element.html())).toEqual('goodbye');
+        expect(lowercase(element.html())).toEqual('goodbye');
       }));
 
       it('should not cause infinite recursion for trustAsHtml object watches',
@@ -243,7 +243,7 @@ describe('ngBind*', function() {
           return $sce.trustAsHtml('<div onclick="">hello</div>');
         };
         $rootScope.$digest();
-        expect(angular.lowercase(element.html())).toEqual('<div onclick="">hello</div>');
+        expect(lowercase(element.html())).toEqual('<div onclick="">hello</div>');
       }));
 
       it('should handle custom $sce objects', function() {
@@ -266,10 +266,10 @@ describe('ngBind*', function() {
           var html = 'hello';
           $rootScope.getHtml = function() { return $sce.trustAsHtml(html); };
           $rootScope.$digest();
-          expect(angular.lowercase(element.html())).toEqual('hello');
+          expect(lowercase(element.html())).toEqual('hello');
           html = 'goodbye';
           $rootScope.$digest();
-          expect(angular.lowercase(element.html())).toEqual('goodbye');
+          expect(lowercase(element.html())).toEqual('goodbye');
         });
       });
 
@@ -280,7 +280,7 @@ describe('ngBind*', function() {
           element = $compile('<div ng-bind-html="html"></div>')($rootScope);
           $rootScope.html = '<div onclick="">hello</div>';
           $rootScope.$digest();
-          expect(angular.lowercase(element.html())).toEqual('<div>hello</div>');
+          expect(lowercase(element.html())).toEqual('<div>hello</div>');
         }));
       });
     });
diff --git a/test/ngSanitize/directive/ngBindHtmlSpec.js b/test/ngSanitize/directive/ngBindHtmlSpec.js
@@ -8,7 +8,7 @@ describe('ngBindHtml', function() {
     var element = $compile('<div ng-bind-html="html"></div>')($rootScope);
     $rootScope.html = '<div unknown>hello</div>';
     $rootScope.$digest();
-    expect(angular.lowercase(element.html())).toEqual('<div>hello</div>');
+    expect(lowercase(element.html())).toEqual('<div>hello</div>');
   }));
 
 
@@ -18,11 +18,11 @@ describe('ngBindHtml', function() {
     angular.forEach([null, undefined, ''], function(val) {
       $rootScope.html = 'some val';
       $rootScope.$digest();
-      expect(angular.lowercase(element.html())).toEqual('some val');
+      expect(lowercase(element.html())).toEqual('some val');
 
       $rootScope.html = val;
       $rootScope.$digest();
-      expect(angular.lowercase(element.html())).toEqual('');
+      expect(lowercase(element.html())).toEqual('');
     });
   }));
 });

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ ngTouch.info({ angularVersion: '"NG_VERSION_FULL"' });`
`29`	`29`	`ngTouch.provider('$touch', $TouchProvider);`
`30`	`30`
`31`	`31`	`function nodeName_(element) {`
`32`		`- return angular.lowercase(element.nodeName \|\| (element[0] && element[0].nodeName));`
	`32`	`+ return angular.$$lowercase(element.nodeName \|\| (element[0] && element[0].nodeName));`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -11388,7 +11388,7 @@ describe('$compile', function() {`
`11388`	`11388`	`element = $compile('<iframe srcdoc="{{html}}"></iframe>')($rootScope);`
`11389`	`11389`	`$rootScope.html = $sce.trustAsHtml('<div onclick="">hello</div>');`
`11390`	`11390`	`$rootScope.$digest();`
`11391`		`- expect(angular.lowercase(element.attr('srcdoc'))).toEqual('<div onclick="">hello</div>');`
	`11391`	`+ expect(lowercase(element.attr('srcdoc'))).toEqual('<div onclick="">hello</div>');`
`11392`	`11392`	`}));`
`11393`	`11393`	`});`
`11394`	`11394`	`}`