Forward the setup short-lived token Promise

alextu · alextu · commit bdc7162ff9d1 · 2024-06-17T19:03:10.000+02:00
This caused a race condition not allowing the short-lived token to be returned in time before the setup finished.
diff --git a/sources/src/develocity/build-scan.ts b/sources/src/develocity/build-scan.ts
@@ -23,7 +23,7 @@ export async function setup(config: BuildScanConfig): Promise<void> {
     maybeExportVariableNotEmpty('GRADLE_PLUGIN_REPOSITORY_USERNAME', config.getGradlePluginRepositoryUsername())
     maybeExportVariableNotEmpty('GRADLE_PLUGIN_REPOSITORY_PASSWORD', config.getGradlePluginRepositoryPassword())
 
-    setupToken(config.getDevelocityAccessKey(), config.getDevelocityTokenExpiry())
+    return setupToken(config.getDevelocityAccessKey(), config.getDevelocityTokenExpiry())
 }
 
 function maybeExportVariable(variableName: string, value: unknown): void {

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export async function setup(config: BuildScanConfig): Promise<void> {`
`23`	`23`	`maybeExportVariableNotEmpty('GRADLE_PLUGIN_REPOSITORY_USERNAME', config.getGradlePluginRepositoryUsername())`
`24`	`24`	`maybeExportVariableNotEmpty('GRADLE_PLUGIN_REPOSITORY_PASSWORD', config.getGradlePluginRepositoryPassword())`
`25`	`25`
`26`		`- setupToken(config.getDevelocityAccessKey(), config.getDevelocityTokenExpiry())`
	`26`	`+ return setupToken(config.getDevelocityAccessKey(), config.getDevelocityTokenExpiry())`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`function maybeExportVariable(variableName: string, value: unknown): void {`