Skip to content

Commit 9524bb8

Browse files
committed
fix: mips softfloat/hardfloat handling
1 parent a8c1674 commit 9524bb8

File tree

4 files changed

+28
-14
lines changed

4 files changed

+28
-14
lines changed

deb/deb.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,6 @@ func ensureValidArch(info *nfpm.Info) *nfpm.Info {
5151
info.Arch = info.Deb.Arch
5252
} else if arch, ok := archToDebian[info.Arch]; ok {
5353
info.Arch = arch
54-
} else {
55-
for k, v := range archToDebian {
56-
if strings.HasPrefix(info.Arch, k) {
57-
info.Arch = v
58-
break
59-
}
60-
}
6154
}
6255

6356
return info

nfpm.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -479,6 +479,12 @@ func WithDefaults(info *Info) *Info {
479479
if info.Arch == "" {
480480
info.Arch = "amd64"
481481
}
482+
if strings.HasPrefix(info.Arch, "mips") {
483+
info.Arch = strings.NewReplacer(
484+
"softfloat", "",
485+
"hardfloat", "",
486+
).Replace(info.Arch)
487+
}
482488
if info.Version == "" {
483489
info.Version = "v0.0.0-rc0"
484490
}

nfpm_test.go

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,28 @@ func TestDefaults(t *testing.T) {
119119
},
120120
}, *got)
121121
})
122+
t.Run("mips softfloat", func(t *testing.T) {
123+
makeinfo := func() nfpm.Info {
124+
return nfpm.Info{
125+
Platform: "linux",
126+
Arch: "mips64softfloat",
127+
}
128+
}
129+
info := makeinfo()
130+
nfpm.WithDefaults(&info)
131+
require.Equal(t, "mips64", info.Arch)
132+
})
133+
t.Run("mips softfloat", func(t *testing.T) {
134+
makeinfo := func() nfpm.Info {
135+
return nfpm.Info{
136+
Platform: "linux",
137+
Arch: "mips64hardfloat",
138+
}
139+
}
140+
info := makeinfo()
141+
nfpm.WithDefaults(&info)
142+
require.Equal(t, "mips64", info.Arch)
143+
})
122144
}
123145

124146
func TestPrepareForPackager(t *testing.T) {

rpm/rpm.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,6 @@ func ensureValidArch(info *nfpm.Info) *nfpm.Info {
7575
info.Arch = info.RPM.Arch
7676
} else if arch, ok := archToRPM[info.Arch]; ok {
7777
info.Arch = arch
78-
} else {
79-
for k, v := range archToRPM {
80-
if strings.HasPrefix(info.Arch, k) {
81-
info.Arch = v
82-
break
83-
}
84-
}
8578
}
8679

8780
return info

0 commit comments

Comments
 (0)