Skip to content

Commit 56775a6

Browse files
authored
chore: add integration test running in docker container (#2613)
In this PR: - In the integration test, run `generate_repo.py` and `generate_pr_description.py` in docker container. - Remove test image in cloud build. Context: In this [log](https://github.com/googleapis/google-cloud-java/actions/runs/8445620169/job/23133097820), the nightly generation job only took 3 mins. After investigation, we found out that removing `main` method in `generate_repo.py` (#2598) caused the CLI is not running despite that the job returns successfully. This non-explicit failure demonstrated that there's difference between calling CLI (`generate` method in `generate_repo.py`) and its implementation (`generate_from_yaml` method in `generate_repo.py`). We decided to change the integration test to run the CLI in docker container, rather than testing `generate_from_yaml` because it is the containerized CLI will be used in downstream libraries.
1 parent d0c5191 commit 56775a6

File tree

4 files changed

+179
-178
lines changed

4 files changed

+179
-178
lines changed

.cloudbuild/library_generation/cloudbuild-test-library-generation.yaml

-31
This file was deleted.

.github/workflows/verify_library_generation.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ jobs:
4848
shell: bash
4949
run: |
5050
set -x
51-
git config --global user.email "[email protected]"
52-
git config --global user.name "Github Workflow"
5351
python -m unittest library_generation/test/integration_tests.py
5452
unit_tests:
5553
strategy:

library_generation/test/container_integration_tests.sh

-49
This file was deleted.

0 commit comments

Comments
 (0)