fix: correct TypeError and comparison issues discovered in DateArray compliance tests #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: add a test session with prerelease versions of dependencies
This makes them consistent with other date/time dtypes, as well as internally consistent with the advertised `dtype.na_value`. BREAKING-CHANGE: dbdate and dbtime dtypes return NaT instead of None for missing values Release-As: 0.4.0
product-auto-label
bot
added
the
api: bigquery
…types-pandas into issue28-TypeError
parthea
approved these changes
Mar 10, 2022
.github/workflows/unittest.yml
Outdated
| @@ -31,6 +31,33 @@ jobs: | |||
| name: coverage-artifacts | |||
| path: .coverage-${{ matrix.python }} | |||
|
|
|||
| compliance: | |||
There was a problem hiding this comment.
alternatively, you could pull this into a separate file called unittest-compliance.yml and remove the customizations in owlbot.py for .github/workflows/unittest.yml. Owlbot shouldn't overwrite the changes because unittest-compliance.yml doesn't exist in templates.
There was a problem hiding this comment.
I'll give that a try! I was thinking mostly about having this count towards coverage, but I see that specifically calls out tests/unit, so this isn't as important.
|
|
||
|
|
||
| class TestGetitem(base.BaseGetitemTests): | ||
| def test_take_na_value_other_date(self): |
There was a problem hiding this comment.
It would be helpful to have an additional comment in the test to clarify the expected behaviour
There was a problem hiding this comment.
👍 Would have been nice if pandas had a bit more of an explanatory comment, but I'll try and deduce why this test was added in pandas-dev/pandas#20814. Perhaps it's not even necessary in general?
There was a problem hiding this comment.
Removed, as most other extension dtype tests don't have it.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.1...v0.4.0) (2022-03-24) ### ⚠ BREAKING CHANGES * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * dbdate and dbtime dtypes return NaT instead of None for missing values ### Features * dbdate and dbtime support numpy.datetime64 values in array constructor ([1db1357](1db1357)) ### Bug Fixes * address failing 2D array compliance tests in DateArray ([#64](#64)) ([b771e05](b771e05)) * address failing tests with pandas 1.5.0 ([#82](#82)) ([38ac28d](38ac28d)) * allow comparison with scalar values ([#88](#88)) ([7495698](7495698)) * avoid TypeError when using sorted search ([#84](#84)) ([42bc2d9](42bc2d9)) * correct TypeError and comparison issues discovered in DateArray compliance tests ([#79](#79)) ([1e979cf](1e979cf)) * dbdate and dbtime support set item with null values ([#85](#85)) ([1db1357](1db1357)) * use `pandas.NaT` for missing values in dbdate and dbtime dtypes ([#67](#67)) ([f903c2c](f903c2c)) * use public pandas APIs where possible ([#60](#60)) ([e9d41d1](e9d41d1)) ### Tests * add dbtime compliance tests ([#90](#90)) ([f14fb2b](f14fb2b)) * add final dbdate compliance tests and sort ([#89](#89)) ([efe7e6d](efe7e6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #64 was getting long, this pulls out some of the smaller changes for easier review.
The compliance tests are modeled after https://github.com/pandas-dev/pandas/blob/main/pandas/tests/extension/decimal/test_decimal.py, including the order of classes in the test suite. "Reduce" classes are skipped due to #78
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #28 🦕
TODO: