-
Notifications
You must be signed in to change notification settings - Fork 6
tests failing locally with pandas 0.24.2 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jimfulton Is this a known issue? Strange that CI doesn't seem to have caught it with the same tests in googleapis/python-bigquery#972 |
No.
The target of that PR is BigQuery V3, which requires pandas >= 1.0.0, so I stopped testing with pandas 0.24. I had this working with 0.24 before, with additional code, which I removed, because it wasn't needed. I can probably get that working here if you want. The tests pass for me on that branch for Python 3.0/pandas 1.0.0. This repo isn't configured to run pandas 1.0.0. However, if I run the Python 3.6 tests with pandas 1.0.0 here I get two shallow test failures because we're constraining Note that in googleapis/python-bigquery#972, we don't constrain |
The fix for 0.24 was much simpler than expected. If I'd known that, I wouldn't have split this issue and the two PRs. |
Glad to hear it!
Ah. That explains it. Since we import |
pandas 0.24.2
The text was updated successfully, but these errors were encountered: