Skip to content

tests.unit.test_arrow: many tests failed #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flaky-bot bot opened this issue Dec 23, 2023 · 4 comments · Fixed by #238
Closed

tests.unit.test_arrow: many tests failed #234

flaky-bot bot opened this issue Dec 23, 2023 · 4 comments · Fixed by #238
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Dec 23, 2023

Many tests failed at the same time in this package.

  • I will close this issue when there are no more failures in this package and
    there is at least one pass.
  • No new issues will be filed for this package until this issue is closed.
  • If there are already issues for individual test cases, I will close them when
    the corresponding test passes. You can close them earlier, if you prefer, and
    I won't reopen them while this issue is still open.

Here are the tests that failed:

  • test_series_from_arrow[expected0-pyarrow_array0]
  • test_series_from_arrow[expected1-pyarrow_array1]
  • test_series_from_arrow[expected2-pyarrow_array2]
  • test_series_from_arrow[expected3-pyarrow_array3]
  • test_series_from_arrow[expected4-pyarrow_array4]
  • test_series_from_arrow[expected5-pyarrow_array5]
  • test_series_from_arrow[expected6-pyarrow_array6]
  • test_series_from_arrow[expected7-pyarrow_array7]
  • test_series_from_arrow[expected8-pyarrow_array8]
  • test_series_from_arrow[expected9-pyarrow_array9]
  • test_series_from_arrow[expected10-pyarrow_array10]
  • test_series_from_arrow[expected11-pyarrow_array11]
  • test_series_from_arrow[expected12-pyarrow_array12]
  • test_series_from_arrow[expected13-pyarrow_array13]
  • test_series_from_arrow[expected14-pyarrow_array14]
  • test_series_from_arrow[expected15-pyarrow_array15]
  • test_series_from_arrow[expected16-pyarrow_array16]
  • test_series_from_arrow[expected17-pyarrow_array17]
  • test_series_from_arrow[time-nanoseconds-arrow-round-trip]
  • test_series_from_arrow[time-nanoseconds-arrow-from-string] (tests.unit.test_arrow: test_series_from_arrow[time-nanoseconds-arrow-from-string] failed #120)
  • test_dataframe_from_arrow

commit: 12156f4
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. labels Dec 23, 2023
Copy link
Author

flaky-bot bot commented Dec 23, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (12156f4), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Dec 23, 2023
@Linchin
Copy link
Contributor

Linchin commented Jan 16, 2024

This has something to do with a pandas release candidate pandas==2.2.0rc0. In this release candidate, make_block() is deprecated. It got quickly reverted for the same issue we are encountering here, as pyarrow is still using this method. We will keep this issue open, wait for the newer pre-release version of pandas to come out, and close this issue when the tests stop failing.

@chalmerlowe chalmerlowe added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 17, 2024
@chalmerlowe
Copy link
Collaborator

chalmerlowe commented Jan 19, 2024

@Linchin Rather than sitting on this and waiting for pandas to change their release candidate (rc): I would suggest we update our install instructions to not use this particular rc during testing so that this issue can be closed.

  • pandas==2.2.0rc0

I would be very specific in pinpointing this version versus some sort of greater than equality check so that we don't accidentally prevent it from trying new versions when 2.2.0rc1 OR higher rolls out.

@Linchin
Copy link
Contributor

Linchin commented Jan 19, 2024

That's a great idea! I'll do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants