Skip to content

chore: address issues identified in code review on pandas docs PR #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tswast opened this issue Mar 3, 2023 · 4 comments
Open

chore: address issues identified in code review on pandas docs PR #175

tswast opened this issue Mar 3, 2023 · 4 comments
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Collaborator

tswast commented Mar 3, 2023

pandas-dev/pandas#45544 (review)

Once we've tried out those suggestions, I think it'd be good to re-open that PR so that we're using publicly documented methods here.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Mar 3, 2023
@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Mar 29, 2023
@MichaelTiemannOSC
Copy link

+1

Can we get this back on track?

@chalmerlowe
Copy link
Collaborator

@tswast

This appears to be a reminder to head off to pandas to get a PR finalized over there.
I see that the PR (and a related one) did not get finalized.

Do you have strong feelings about this? It is stale.

@tswast
Copy link
Collaborator Author

tswast commented Apr 18, 2025

Additional comments in pandas-dev/pandas#56755 that might affect our implementation here.

@tswast
Copy link
Collaborator Author

tswast commented Apr 18, 2025

Discussed offline that all current uses of numpy extension array are more-or-less superseded by ArrowDtype in pandas itself, so this package is mostly useful for older pandas + pyarrow combinations. If we do continue to use numpy extension array, though, this issue is an important one to keep open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tswast @chalmerlowe @MichaelTiemannOSC