-
Notifications
You must be signed in to change notification settings - Fork 6
fix: remove python version upper bound #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JacobHayes thanks for submitting this PR. I am checking with some colleagues to see whether there was a particular reason to take this approach. More to come. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think the two failing tests are flakes but not sure about "OwlBot Post Processor". |
there is a bug in the pandas release candidate code that handles time down to the nanosecond and it is causing some tests to fail. |
Capping to <3.11 prevents projects from using (or testing) this package on 3.11 (which I'd like to do for internal projects), so unless there is a known breaking issue in 3.11, this removes the pin. There may be some conflicting opinions, but this post lays out a couple challenges with libraries pinning upper bound. Notably, neither pandas nor pyarrow set a python upper bound.
--
I'm just making the PR real quick since it is a small change, but happy to close if there are concerns (or open an issue if it needs further discussion).
Fixes #<issue_number_goes_here> 🦕