Skip to content

fix: remove python version upper bound #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2022
Merged

fix: remove python version upper bound #145

merged 2 commits into from
Sep 13, 2022

Conversation

JacobHayes
Copy link
Contributor

@JacobHayes JacobHayes commented Sep 7, 2022

Capping to <3.11 prevents projects from using (or testing) this package on 3.11 (which I'd like to do for internal projects), so unless there is a known breaking issue in 3.11, this removes the pin. There may be some conflicting opinions, but this post lays out a couple challenges with libraries pinning upper bound. Notably, neither pandas nor pyarrow set a python upper bound.

--

I'm just making the PR real quick since it is a small change, but happy to close if there are concerns (or open an issue if it needs further discussion).

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@JacobHayes JacobHayes requested a review from a team as a code owner September 7, 2022 22:04
@JacobHayes JacobHayes requested review from a team and chalmerlowe September 7, 2022 22:04
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Sep 7, 2022
@chalmerlowe
Copy link
Collaborator

@JacobHayes thanks for submitting this PR. I am checking with some colleagues to see whether there was a particular reason to take this approach. More to come.

Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacobHayes
Copy link
Contributor Author

I think the two failing tests are flakes but not sure about "OwlBot Post Processor".

@chalmerlowe
Copy link
Collaborator

there is a bug in the pandas release candidate code that handles time down to the nanosecond and it is causing some tests to fail.
They know about about it and last I checked, it was in the works as part of the milestone release. Not super worried about the tests. Will check on what might be the problem with owlbot and see about getting this merged.

@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2022
@parthea parthea changed the title Remove python version upper bound fix: remove python version upper bound Sep 13, 2022
@parthea parthea merged commit a361806 into googleapis:main Sep 13, 2022
@JacobHayes JacobHayes deleted the py3.11 branch September 13, 2022 16:59
@tswast tswast mentioned this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants