Skip to content

TST: flake8 should run on all python builds #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
parthea opened this issue Jun 7, 2017 · 2 comments
Closed

TST: flake8 should run on all python builds #51

parthea opened this issue Jun 7, 2017 · 2 comments
Labels
type: process A process-related concern. May include testing, release, or the like.
Milestone
0.2.0

Comments

@parthea
Copy link
Contributor

parthea commented Jun 7, 2017 •
edited
Loading

From PR #39 ,
I received the following warning when running flake8 on branch tswast:gbq-37 but Travis did not report the warning.

Local run:

tony@tonypc:~/pydata-pandas-gbq$ flake8 pandas_gbq 
pandas_gbq/tests/test_gbq.py:136:61: F841 local variable 'e' is assigned to but never used

On Travis:
https://travis-ci.org/tswast/pandas-gbq/jobs/234914390
@parthea parthea mentioned this issue Jun 7, 2017
Merged
@parthea
Copy link
Contributor Author

parthea commented Jun 7, 2017

Flake8 is currently only running on python 3.6 in the Travis environment, whereas my local environment is python 2.7.

@parthea parthea changed the title TST: Travis does not appear to be reporting flake8 warnings BLD: flake8 should run on all python builds Jun 7, 2017
@jreback
Copy link
Contributor

jreback commented Jun 9, 2017

just turn it on additionally for 2.7

@jreback jreback added the type: process A process-related concern. May include testing, release, or the like. label Jun 9, 2017
@jreback jreback changed the title BLD: flake8 should run on all python builds TST: flake8 should run on all python builds Jun 9, 2017
@parthea parthea mentioned this issue Jun 9, 2017
Merged
@jreback jreback added this to the 0.2.0 milestone Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@jreback @parthea