-
Notifications
You must be signed in to change notification settings - Fork 125
Improve InvalidSchema exception by adding specific fields that do not match #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Great suggestion. I think we do a "set difference" in order to discover schema mismatch, so this should be possible to figure out and include in the exception. |
Great, I will start working on it then. |
I'm a bit wary of including this information in the actual exception message due to potential privacy issues around logging. Instead, I'm adding |
So long as we leave out description (and other column metadata like IAM roles), which can contain arbitrary text (possibly, though unlikely to be PII) I do think it would be an improved experience if the string representation of InvalidSchema showed the diff of field names and the types. |
Based on current workloads, staffing, priorities, and the age of this Issue, closing this as will not fix. |
I am talking about this InvalidSchema exception.
It may be useful to show at most 3 (for example) fields that have different types. It should help to debug a type mismatch faster.
The text was updated successfully, but these errors were encountered: