Skip to content

Commit d6b7ab4

Browse files
authored
chore: Multimodal tests to target at BQ prod (#1782)
1 parent cbb5f14 commit d6b7ab4

File tree

5 files changed

+28
-40
lines changed

5 files changed

+28
-40
lines changed

tests/system/conftest.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -920,8 +920,8 @@ def llm_text_pandas_df():
920920

921921

922922
@pytest.fixture(scope="session")
923-
def llm_text_df(test_session, llm_text_pandas_df):
924-
return test_session.read_pandas(llm_text_pandas_df)
923+
def llm_text_df(session, llm_text_pandas_df):
924+
return session.read_pandas(llm_text_pandas_df)
925925

926926

927927
@pytest.fixture(scope="session")
@@ -1494,9 +1494,9 @@ def images_uris() -> list[str]:
14941494

14951495
@pytest.fixture(scope="session")
14961496
def images_mm_df(
1497-
images_uris, test_session: bigframes.Session, bq_connection: str
1497+
images_uris, session: bigframes.Session, bq_connection: str
14981498
) -> bpd.DataFrame:
1499-
blob_series = bpd.Series(images_uris, session=test_session).str.to_blob(
1499+
blob_series = bpd.Series(images_uris, session=session).str.to_blob(
15001500
connection=bq_connection
15011501
)
15021502
return blob_series.rename("blob_col").to_frame()
@@ -1518,8 +1518,6 @@ def pdf_gcs_path() -> str:
15181518

15191519
@pytest.fixture(scope="session")
15201520
def pdf_mm_df(
1521-
pdf_gcs_path, test_session: bigframes.Session, bq_connection: str
1521+
pdf_gcs_path, session: bigframes.Session, bq_connection: str
15221522
) -> bpd.DataFrame:
1523-
return test_session.from_glob_path(
1524-
pdf_gcs_path, name="pdf", connection=bq_connection
1525-
)
1523+
return session.from_glob_path(pdf_gcs_path, name="pdf", connection=bq_connection)

tests/system/large/blob/test_function.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ def images_output_uris(images_output_folder: str) -> list[str]:
5353

5454
def test_blob_exif(
5555
bq_connection: str,
56-
test_session: bigframes.Session,
56+
session: bigframes.Session,
5757
):
58-
exif_image_df = test_session.from_glob_path(
58+
exif_image_df = session.from_glob_path(
5959
"gs://bigframes_blob_test/images_exif/*",
6060
name="blob_col",
6161
connection=bq_connection,
@@ -64,7 +64,7 @@ def test_blob_exif(
6464
actual = exif_image_df["blob_col"].blob.exif(connection=bq_connection)
6565
expected = bpd.Series(
6666
['{"ExifOffset": 47, "Make": "MyCamera"}'],
67-
session=test_session,
67+
session=session,
6868
dtype=dtypes.JSON_DTYPE,
6969
)
7070
pd.testing.assert_series_equal(
@@ -79,9 +79,9 @@ def test_blob_image_blur_to_series(
7979
images_mm_df: bpd.DataFrame,
8080
bq_connection: str,
8181
images_output_uris: list[str],
82-
test_session: bigframes.Session,
82+
session: bigframes.Session,
8383
):
84-
series = bpd.Series(images_output_uris, session=test_session).str.to_blob(
84+
series = bpd.Series(images_output_uris, session=session).str.to_blob(
8585
connection=bq_connection
8686
)
8787

@@ -147,9 +147,9 @@ def test_blob_image_resize_to_series(
147147
images_mm_df: bpd.DataFrame,
148148
bq_connection: str,
149149
images_output_uris: list[str],
150-
test_session: bigframes.Session,
150+
session: bigframes.Session,
151151
):
152-
series = bpd.Series(images_output_uris, session=test_session).str.to_blob(
152+
series = bpd.Series(images_output_uris, session=session).str.to_blob(
153153
connection=bq_connection
154154
)
155155

@@ -217,9 +217,9 @@ def test_blob_image_normalize_to_series(
217217
images_mm_df: bpd.DataFrame,
218218
bq_connection: str,
219219
images_output_uris: list[str],
220-
test_session: bigframes.Session,
220+
session: bigframes.Session,
221221
):
222-
series = bpd.Series(images_output_uris, session=test_session).str.to_blob(
222+
series = bpd.Series(images_output_uris, session=session).str.to_blob(
223223
connection=bq_connection
224224
)
225225

tests/system/small/blob/test_io.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919

2020

2121
def test_blob_create_from_uri_str(
22-
bq_connection: str, test_session: bigframes.Session, images_uris
22+
bq_connection: str, session: bigframes.Session, images_uris
2323
):
24-
uri_series = bpd.Series(images_uris, session=test_session)
24+
uri_series = bpd.Series(images_uris, session=session)
2525
blob_series = uri_series.str.to_blob(connection=bq_connection)
2626

2727
pd_blob_df = blob_series.struct.explode().to_pandas()
@@ -40,9 +40,9 @@ def test_blob_create_from_uri_str(
4040

4141

4242
def test_blob_create_from_glob_path(
43-
bq_connection: str, test_session: bigframes.Session, images_gcs_path, images_uris
43+
bq_connection: str, session: bigframes.Session, images_gcs_path, images_uris
4444
):
45-
blob_df = test_session.from_glob_path(
45+
blob_df = session.from_glob_path(
4646
images_gcs_path, connection=bq_connection, name="blob_col"
4747
)
4848
pd_blob_df = (
@@ -68,11 +68,11 @@ def test_blob_create_from_glob_path(
6868

6969

7070
def test_blob_create_read_gbq_object_table(
71-
bq_connection: str, test_session: bigframes.Session, images_gcs_path, images_uris
71+
bq_connection: str, session: bigframes.Session, images_gcs_path, images_uris
7272
):
73-
obj_table = test_session._create_object_table(images_gcs_path, bq_connection)
73+
obj_table = session._create_object_table(images_gcs_path, bq_connection)
7474

75-
blob_df = test_session.read_gbq_object_table(obj_table, name="blob_col")
75+
blob_df = session.read_gbq_object_table(obj_table, name="blob_col")
7676
pd_blob_df = (
7777
blob_df["blob_col"]
7878
.struct.explode()

tests/system/small/ml/test_multimodal_llm.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323

2424
@pytest.mark.flaky(retries=2)
2525
def test_multimodal_embedding_generator_predict_default_params_success(
26-
images_mm_df, test_session, bq_connection
26+
images_mm_df, session, bq_connection
2727
):
2828
text_embedding_model = llm.MultimodalEmbeddingGenerator(
29-
connection_name=bq_connection, session=test_session
29+
connection_name=bq_connection, session=session
3030
)
3131
df = text_embedding_model.predict(images_mm_df).to_pandas()
3232
utils.check_pandas_df_schema_and_index(
@@ -48,10 +48,10 @@ def test_multimodal_embedding_generator_predict_default_params_success(
4848
)
4949
@pytest.mark.flaky(retries=2)
5050
def test_gemini_text_generator_multimodal_input(
51-
images_mm_df: bpd.DataFrame, model_name, test_session, bq_connection
51+
images_mm_df: bpd.DataFrame, model_name, session, bq_connection
5252
):
5353
gemini_text_generator_model = llm.GeminiTextGenerator(
54-
model_name=model_name, connection_name=bq_connection, session=test_session
54+
model_name=model_name, connection_name=bq_connection, session=session
5555
)
5656
pd_df = gemini_text_generator_model.predict(
5757
images_mm_df, prompt=["Describe", images_mm_df["blob_col"]]
@@ -73,10 +73,10 @@ def test_gemini_text_generator_multimodal_input(
7373
)
7474
@pytest.mark.flaky(retries=2)
7575
def test_gemini_text_generator_multimodal_structured_output(
76-
images_mm_df: bpd.DataFrame, model_name, test_session, bq_connection
76+
images_mm_df: bpd.DataFrame, model_name, session, bq_connection
7777
):
7878
gemini_text_generator_model = llm.GeminiTextGenerator(
79-
model_name=model_name, connection_name=bq_connection, session=test_session
79+
model_name=model_name, connection_name=bq_connection, session=session
8080
)
8181
output_schema = {
8282
"bool_output": "bool",

tests/system/small/test_session.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1814,16 +1814,6 @@ def test_read_json_gcs_default_engine(session, scalars_dfs, gcs_folder):
18141814
pd.testing.assert_series_equal(df.dtypes, scalars_df.dtypes)
18151815

18161816

1817-
def test_read_gbq_test(test_session: bigframes.Session):
1818-
test_project_id = "bigframes-dev"
1819-
test_dataset_id = "test_env_only"
1820-
test_table_id = "one_table"
1821-
table_id = f"{test_project_id}.{test_dataset_id}.{test_table_id}"
1822-
actual = test_session.read_gbq(table_id).to_pandas()
1823-
1824-
assert actual.shape == (1, 1)
1825-
1826-
18271817
@pytest.mark.parametrize(
18281818
("query_or_table", "index_col", "columns"),
18291819
[

0 commit comments

Comments
 (0)