Skip to content

Commit fe03d02

Browse files
fix: Updated logging in the client pool and client factory to log information about the required transport and actual transport used. (#1853)
1 parent 3dd53cf commit fe03d02

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

dev/src/index.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,12 @@ export class Firestore implements firestore.Firestore {
617617
);
618618
}
619619

620-
logger('Firestore', null, 'Initialized Firestore GAPIC Client');
620+
logger(
621+
'clientFactory',
622+
null,
623+
'Initialized Firestore GAPIC Client (useFallback: %s)',
624+
useFallback
625+
);
621626
return client;
622627
},
623628
/* clientDestructor= */ client => client.close()

dev/src/pool.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,12 @@ export class ClientPool<T> {
122122
this.concurrentOperationLimit - selectedClientRequestCount
123123
);
124124
} else {
125-
logger('ClientPool.acquire', requestTag, 'Creating a new client');
125+
logger(
126+
'ClientPool.acquire',
127+
requestTag,
128+
'Creating a new client (requiresGrpc: %s)',
129+
requiresGrpc
130+
);
126131
selectedClient = this.clientFactory(requiresGrpc);
127132
selectedClientRequestCount = 0;
128133
assert(

0 commit comments

Comments
 (0)