Skip to content

Commit a573b79

Browse files
chore: deep-preserve for ITFoldersTest (#2357)
Owlbot PRs will be removing this IT. This PR prevents it. I found out about this by testing [new GAPIC generation in sdk-platform-java](https://togithub.com/googleapis/sdk-platform-java/tree/main/library_generation) (I generated a post-processed library and the diff between my generation and the `java-storage` repo was this one missing file) OwlBot CLI's `copy-code` output (from a local generation): ``` ... rm /repo/google-cloud-storage-control/src/main/java/com/google/storage/control/v2/StorageControlClient.java rm /repo/google-cloud-storage-control/src/main/java/com/google/storage/control/v2/StorageControlSettings.java rm /repo/google-cloud-storage-control/src/main/java/com/google/storage/control/v2/stub/GrpcStorageControlCallableFactory.java rm /repo/google-cloud-storage-control/src/main/java/com/google/storage/control/v2/stub/GrpcStorageControlStub.java rm /repo/google-cloud-storage-control/src/main/java/com/google/storage/control/v2/stub/StorageControlStub.java rm /repo/google-cloud-storage-control/src/main/java/com/google/storage/control/v2/stub/StorageControlStubSettings.java rm /repo/google-cloud-storage-control/src/main/resources/com/google/storage/control/v2/gapic_metadata.json rm /repo/google-cloud-storage-control/src/main/resources/META-INF/native-image/com.google.storage.control.v2/reflect-config.json // problematic removal rm /repo/google-cloud-storage- control/src/test/java/com/google/storage/control/v2/ITFoldersTest.java rm /repo/google-cloud-storage-control/src/test/java/com/google/storage/control/v2/MockStorageControl.java rm /repo/google-cloud-storage-control/src/test/java/com/google/storage/control/v2/MockStorageControlImpl.java rm /repo/google-cloud-storage-control/src/test/java/com/google/storage/control/v2/StorageControlClientTest.java rmdir /repo/google-cloud-storage-control/src/main/resources/META-INF/native-image/com.google.storage.control.v2 rmdir /repo/gapic-google-cloud-storage-v2/src/main/resources/META-INF/native-image/com.google.storage.v2 rmdir /repo/proto-google-cloud-storage-control-v2/src/main/java/com/google/storage/control/v2 ... ``` @JoeWang1127 @suztomo @blakeli0 I will disable `storage` tests in our hermetic build ITs while this is not merged
1 parent c12d565 commit a573b79

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.github/.OwlBot.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
docker:
1616
image: "gcr.io/cloud-devrel-public-resources/owlbot-java:latest"
1717

18+
deep-preserve-regex:
19+
- "/google-.*/src/test/java/com/google/storage/control/v2/ITFoldersTest.java"
20+
1821
deep-remove-regex:
1922
- "/grpc-google-.*/src"
2023
- "/proto-google-.*/src"

0 commit comments

Comments
 (0)