Skip to content

Commit 2c0a34b

Browse files
authored
chore: Include RENAME in DDL statement list (#2784)
Fixes #2783
1 parent b8d5451 commit 2c0a34b

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/AbstractStatementParser.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ ClientSideStatement getClientSideStatement() {
356356
}
357357

358358
static final Set<String> ddlStatements =
359-
ImmutableSet.of("CREATE", "DROP", "ALTER", "ANALYZE", "GRANT", "REVOKE");
359+
ImmutableSet.of("CREATE", "DROP", "ALTER", "ANALYZE", "GRANT", "REVOKE", "RENAME");
360360
static final Set<String> selectStatements = ImmutableSet.of("SELECT", "WITH", "SHOW");
361361
static final Set<String> dmlStatements = ImmutableSet.of("INSERT", "UPDATE", "DELETE");
362362
private final Set<ClientSideStatementImpl> statements;

google-cloud-spanner/src/test/java/com/google/cloud/spanner/connection/StatementParserTest.java

+13
Original file line numberDiff line numberDiff line change
@@ -553,6 +553,19 @@ public void testIsDdlStatement() {
553553
assertTrue(parser.parse(Statement.of("\t ANALYZE\n ")).isDdl());
554554
assertTrue(parser.parse(Statement.of("/* This is a comment */ ANALYZE ")).isDdl());
555555
assertTrue(parser.parse(Statement.of("-- comment\n ANALYZE ")).isDdl());
556+
assertTrue(parser.parse(Statement.of("RENAME TABLE foo TO foo2")).isDdl());
557+
assertTrue(
558+
parser.parse(Statement.of("/* Fix typo */ RENAME TABLE studens TO students")).isDdl());
559+
assertTrue(
560+
parser.parse(Statement.of("/* Fix typo */ rename TABLE studens TO students")).isDdl());
561+
assertTrue(
562+
parser.parse(Statement.of("RENAME INDEX idx_foo TO idx_students_last_name")).isDdl());
563+
assertTrue(
564+
parser.parse(Statement.of("/* Fix typo */ Rename TABLE studens TO students")).isDdl());
565+
assertTrue(
566+
parser
567+
.parse(Statement.of(" \t\nRENAME\n INDEX idx_foo TO idx_students_last_name"))
568+
.isDdl());
556569
}
557570

558571
@Test

0 commit comments

Comments
 (0)