Skip to content

Commit c2288c9

Browse files
authored
feat: enable last_scanned_row_responses feature flag (#1862)
This enables the last_scanned_row_responses feature flag and updates the unit test for scan markers to have slightly better coverage.
1 parent 220cf4b commit c2288c9

File tree

4 files changed

+22
-2
lines changed

4 files changed

+22
-2
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ If you are using Maven without the BOM, add this to your dependencies:
5050
If you are using Gradle 5.x or later, add this to your dependencies:
5151

5252
```Groovy
53-
implementation platform('com.google.cloud:libraries-bom:26.20.0')
53+
implementation platform('com.google.cloud:libraries-bom:26.21.0')
5454
5555
implementation 'com.google.cloud:google-cloud-bigtable'
5656
```

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,8 @@ private Builder() {
731731
.setTotalTimeout(PRIME_REQUEST_TIMEOUT)
732732
.build());
733733

734-
featureFlags = FeatureFlags.newBuilder().setReverseScans(true);
734+
featureFlags =
735+
FeatureFlags.newBuilder().setReverseScans(true).setLastScannedRowResponses(true);
735736
}
736737

737738
private Builder(EnhancedBigtableStubSettings settings) {

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ public void testFeatureFlags() throws InterruptedException, IOException, Executi
243243
FeatureFlags.parseFrom(BaseEncoding.base64Url().decode(encodedFeatureFlags));
244244

245245
assertThat(featureFlags.getReverseScans()).isTrue();
246+
assertThat(featureFlags.getLastScannedRowResponses()).isTrue();
246247
}
247248

248249
@Test

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/RowMergingCallableTest.java

+18
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,18 @@
4242
public class RowMergingCallableTest {
4343
@Test
4444
public void scanMarker() {
45+
ReadRowsResponse.Builder rrr = ReadRowsResponse.newBuilder();
46+
rrr.addChunksBuilder()
47+
.setRowKey(ByteString.copyFromUtf8("key0"))
48+
.setFamilyName(StringValue.of("f1"))
49+
.setQualifier(BytesValue.of(ByteString.copyFromUtf8("q1")))
50+
.setCommitRow(true);
51+
4552
FakeStreamingApi.ServerStreamingStashCallable<ReadRowsRequest, ReadRowsResponse> inner =
4653
new ServerStreamingStashCallable<>(
4754
Lists.newArrayList(
55+
// send a row
56+
rrr.build(),
4857
// send a scan marker
4958
ReadRowsResponse.newBuilder()
5059
.setLastScannedRowKey(ByteString.copyFromUtf8("key1"))
@@ -56,6 +65,15 @@ public void scanMarker() {
5665

5766
Truth.assertThat(results)
5867
.containsExactly(
68+
Row.create(
69+
ByteString.copyFromUtf8("key0"),
70+
Lists.newArrayList(
71+
RowCell.create(
72+
"f1",
73+
ByteString.copyFromUtf8("q1"),
74+
0,
75+
Lists.newArrayList(),
76+
ByteString.EMPTY))),
5977
Row.create(ByteString.copyFromUtf8("key1"), Lists.<RowCell>newArrayList()));
6078
}
6179

0 commit comments

Comments
 (0)