Skip to content

Commit e6ee13a

Browse files
fix: extra logging for investigation of the stuck case. (#1999)
* fix: extra logging for stuck case * . * . * . * . * . * . * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * . --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent dd13d99 commit e6ee13a

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,13 @@ implementation 'com.google.cloud:google-cloud-bigquerystorage'
5656
If you are using Gradle without BOM, add this to your dependencies:
5757

5858
```Groovy
59-
implementation 'com.google.cloud:google-cloud-bigquerystorage:2.31.0'
59+
implementation 'com.google.cloud:google-cloud-bigquerystorage:2.31.1'
6060
```
6161

6262
If you are using SBT, add this to your dependencies:
6363

6464
```Scala
65-
libraryDependencies += "com.google.cloud" % "google-cloud-bigquerystorage" % "2.31.0"
65+
libraryDependencies += "com.google.cloud" % "google-cloud-bigquerystorage" % "2.31.1"
6666
```
6767

6868
## Authentication

google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,17 @@ private void appendLoop() {
581581
}
582582
}
583583

584-
log.fine("Cleanup starts. Stream: " + streamName + " id: " + writerId);
584+
log.info(
585+
"Cleanup starts. Stream: "
586+
+ streamName
587+
+ " id: "
588+
+ writerId
589+
+ " userClose: "
590+
+ userClosed
591+
+ " final exception: "
592+
+ (this.connectionFinalStatus == null
593+
? "null"
594+
: this.connectionFinalStatus.toString()));
585595
// At this point, the waiting queue is drained, so no more requests.
586596
// We can close the stream connection and handle the remaining inflight requests.
587597
if (streamConnection != null) {
@@ -590,13 +600,13 @@ private void appendLoop() {
590600
}
591601

592602
// At this point, there cannot be more callback. It is safe to clean up all inflight requests.
593-
log.fine(
603+
log.info(
594604
"Stream connection is fully closed. Cleaning up inflight requests. Stream: "
595605
+ streamName
596606
+ " id: "
597607
+ writerId);
598608
cleanupInflightRequests();
599-
log.fine("Append thread is done. Stream: " + streamName + " id: " + writerId);
609+
log.info("Append thread is done. Stream: " + streamName + " id: " + writerId);
600610
}
601611

602612
/*
@@ -809,7 +819,9 @@ private void doneCallback(Throwable finalStatus) {
809819
+ (maxRetryDuration.toMillis()
810820
- (System.currentTimeMillis() - connectionRetryStartTime))
811821
+ ", for stream "
812-
+ streamName);
822+
+ streamName
823+
+ " id:"
824+
+ writerId);
813825
} else {
814826
Exceptions.StorageException storageException = Exceptions.toStorageException(finalStatus);
815827
this.connectionFinalStatus = storageException != null ? storageException : finalStatus;

0 commit comments

Comments
 (0)