Skip to content

Commit 0c5eed1

Browse files
Fix: @nullable annotations on builder methods (#3222)
* Fix @nullable annotations on builder methods This fixes errors in the latest versions of AutoValue ``` google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionSettings.java:225: error: [AutoValueBuilderSetterNullable] Setter methods always return the Builder so @nullable is not appropriate public abstract Builder setUseReadAPI(Boolean useReadAPI); ^ ``` * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Review comments * Review comments * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 94b5b43 commit 0c5eed1

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,13 @@ implementation 'com.google.cloud:google-cloud-bigquery'
6060
If you are using Gradle without BOM, add this to your dependencies:
6161

6262
```Groovy
63-
implementation 'com.google.cloud:google-cloud-bigquery:2.38.2'
63+
implementation 'com.google.cloud:google-cloud-bigquery:2.39.0'
6464
```
6565

6666
If you are using SBT, add this to your dependencies:
6767

6868
```Scala
69-
libraryDependencies += "com.google.cloud" % "google-cloud-bigquery" % "2.38.2"
69+
libraryDependencies += "com.google.cloud" % "google-cloud-bigquery" % "2.39.0"
7070
```
7171
<!-- {x-version-update-end} -->
7272

@@ -351,7 +351,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
351351
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-bigquery/java11.html
352352
[stability-image]: https://img.shields.io/badge/stability-stable-green
353353
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-bigquery.svg
354-
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-bigquery/2.38.2
354+
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-bigquery/2.39.0
355355
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
356356
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
357357
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionSettings.java

-1
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,6 @@ Builder withDefaultValues() {
221221
*
222222
* @param useReadAPI or {@code true} for none
223223
*/
224-
@Nullable
225224
public abstract Builder setUseReadAPI(Boolean useReadAPI);
226225

227226
/**

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ReadClientConnectionConfiguration.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,34 +31,34 @@ public abstract static class Builder {
3131
* Sets the total row count to page row count ratio used to determine whether to us the
3232
* BigQueryStorage Read client to fetch result sets after the first page.
3333
*/
34-
@Nullable
3534
public abstract Builder setTotalToPageRowCountRatio(Long ratio);
3635

3736
/**
3837
* Sets the minimum number of table rows in the query results used to determine whether to us
3938
* the BigQueryStorage Read client to fetch result sets after the first page.
4039
*/
41-
@Nullable
4240
public abstract Builder setMinResultSize(Long numRows);
4341

4442
/**
4543
* Sets the maximum number of table rows allowed in buffer before streaming them to the
4644
* BigQueryResult.
4745
*/
48-
@Nullable
4946
public abstract Builder setBufferSize(Long bufferSize);
5047

5148
/** Creates a {@code ReadClientConnectionConfiguration} object. */
5249
public abstract ReadClientConnectionConfiguration build();
5350
}
5451

5552
/** Returns the totalToPageRowCountRatio in this configuration. */
53+
@Nullable
5654
public abstract Long getTotalToPageRowCountRatio();
5755

5856
/** Returns the minResultSize in this configuration. */
57+
@Nullable
5958
public abstract Long getMinResultSize();
6059

6160
/** Returns the bufferSize in this configuration. */
61+
@Nullable
6262
public abstract Long getBufferSize();
6363

6464
public abstract Builder toBuilder();

0 commit comments

Comments
 (0)