Skip to content

Commit 8af5b89

Browse files
authored
test: skipNativeTests in java-core (#9076)
* test: skipNativeTests in java-core * Clarifying amd option in mvn * Temporarily excluding java-core
1 parent c26f45e commit 8af5b89

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

.kokoro/common.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515

16-
excluded_modules=('gapic-libraries-bom' 'google-cloud-jar-parent' 'google-cloud-pom-parent')
16+
# TODO: remove java-core once we figure out how setup_cloud understands Maven's
17+
# "--also-make-dependents" option. https://github.com/googleapis/google-cloud-java/issues/9088
18+
excluded_modules=('gapic-libraries-bom' 'google-cloud-jar-parent' 'google-cloud-pom-parent' 'java-core')
1719

1820
function retry_with_backoff {
1921
attempts_left=$1
@@ -124,9 +126,10 @@ function generate_modified_modules_list() {
124126

125127
function run_integration_tests() {
126128
printf "Running Integration Tests for:\n%s\n" "$1"
129+
# --also-make-dependents to run other modules that use the affected module
127130
mvn -B ${INTEGRATION_TEST_ARGS} \
128131
-pl "$1" \
129-
-amd \
132+
--also-make-dependents \
130133
-ntp \
131134
-Penable-integration-tests \
132135
-DtrimStackTrace=false \
@@ -151,7 +154,7 @@ function run_graalvm_tests() {
151154

152155
mvn -B ${INTEGRATION_TEST_ARGS} \
153156
-pl "$1" \
154-
-amd \
157+
--also-make-dependents \
155158
-ntp \
156159
-DtrimStackTrace=false \
157160
-Dclirr.skip=true \

java-core/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@
2222
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
2323
<github.global.server>github</github.global.server>
2424
<site.installationModule>google-cloud-core-parent</site.installationModule>
25+
<!-- This module itself does not have integration tests and thus cannot
26+
be tested with native image plugin. Instead, the client libraries that
27+
use this java-core module have integration tests on native image. -->
28+
<skipNativeTests>true</skipNativeTests>
2529
</properties>
2630

2731
<modules>

0 commit comments

Comments
 (0)