storage: don't fail tests loudly if cleanup fails

Sarah Adams · Sarah Adams · commit fa279f9bbe79 · 2016-10-13T20:04:35.000Z
It seems that our integration tests are failing fairly frequently because we are trying to delete an object which has already been deleted. Change-Id: I5861574bb693e16e94b96a81445576429af99b8b Reviewed-on: https://code-review.googlesource.com/8430 Reviewed-by: Ross Light <light@google.com>
diff --git a/storage/integration_test.go b/storage/integration_test.go
@@ -52,7 +52,9 @@ func TestMain(m *testing.M) {
 	exit := m.Run()
 	if integrationTest {
 		if err := cleanup(); err != nil {
-			log.Fatalf("Post-test cleanup failed: %v", err)
+			// No need to be loud if cleanup() fails; we'll get
+			// any undeleted buckets next time.
+			log.Printf("Post-test cleanup failed: %v\n", err)
 		}
 	}
 	os.Exit(exit)

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,9 @@ func TestMain(m *testing.M) {`
`52`	`52`	`exit := m.Run()`
`53`	`53`	`if integrationTest {`
`54`	`54`	`if err := cleanup(); err != nil {`
`55`		`- log.Fatalf("Post-test cleanup failed: %v", err)`
	`55`	`+ // No need to be loud if cleanup() fails; we'll get`
	`56`	`+ // any undeleted buckets next time.`
	`57`	`+ log.Printf("Post-test cleanup failed: %v\n", err)`
`56`	`58`	`}`
`57`	`59`	`}`
`58`	`60`	`os.Exit(exit)`