bigquery: shorten Disposition field names

In LoadConfig, shorten TableXXXDispostion to XXXDisposition.

The type and doc comment suffice.

Change-Id: I76045f8614818ed761a0f627ff20fd7f95618659
Reviewed-on: https://code-review.googlesource.com/8390
Reviewed-by: Michael McGreevy <[email protected]>

Author: jba

bigquery/load_test.go

@@ -280,8 +280,8 @@ func TestConfiguringLoader(t *testing.T) {
 	want.Configuration.Load.WriteDisposition = "WRITE_TRUNCATE"
 
 	loader := dst.LoaderFrom(src)
-	loader.TableCreateDisposition = CreateNever
-	loader.TableWriteDisposition = WriteTruncate
+	loader.CreateDisposition = CreateNever
+	loader.WriteDisposition = WriteTruncate
 
 	if _, err := loader.Run(context.Background()); err != nil {
 		t.Errorf("err calling Loader.Run: %v", err)

bigquery/table.go

@@ -327,13 +327,13 @@ type LoadConfig struct {
 	// Dst is the table into which the data will be loaded.
 	Dst *Table
 
-	// TableCreateDisposition specifies the circumstances under which the destination table will be created.
+	// CreateDisposition specifies the circumstances under which the destination table will be created.
 	// The default is CreateIfNeeded.
-	TableCreateDisposition TableCreateDisposition
+	CreateDisposition TableCreateDisposition
 
-	// TableWriteDisposition specifies how existing data in the destination table is treated.
+	// WriteDisposition specifies how existing data in the destination table is treated.
 	// The default is WriteAppend.
-	TableWriteDisposition TableWriteDisposition
+	WriteDisposition TableWriteDisposition
 }
 
 // A Loader loads data from Google Cloud Storage into a BigQuery table.
@@ -359,8 +359,8 @@ func (l *Loader) Run(ctx context.Context) (*Job, error) {
 	job := &bq.Job{
 		Configuration: &bq.JobConfiguration{
 			Load: &bq.JobConfigurationLoad{
-				CreateDisposition: string(l.TableCreateDisposition),
-				WriteDisposition:  string(l.TableWriteDisposition),
+				CreateDisposition: string(l.CreateDisposition),
+				WriteDisposition:  string(l.WriteDisposition),
 			},
 		},
 	}