Skip to content

Commit 27e94c0

Browse files
authored
fix: pinning commons-codec dependency in google-api-client (#2201)
Turns out https://togithub.com/googleapis/google-api-java-client/pull/2195 only fixed half the issue. `commons-codec` needs to be declared as a dependency within the `google-api-client`'s `pom.xml` as well.
1 parent 7cf3cc4 commit 27e94c0

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

google-api-client/pom.xml

+14
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,13 @@
104104
</execution>
105105
</executions>
106106
</plugin>
107+
<plugin>
108+
<groupId>org.apache.maven.plugins</groupId>
109+
<artifactId>maven-dependency-plugin</artifactId>
110+
<configuration>
111+
<usedDependencies>commons-codec:commons-codec</usedDependencies>
112+
</configuration>
113+
</plugin>
107114
</plugins>
108115

109116
<resources>
@@ -117,6 +124,13 @@
117124
</resources>
118125
</build>
119126
<dependencies>
127+
<dependency>
128+
<!-- google-api-client itself does not touch commons-codec. Its
129+
httpclient's dependency. For security advisories in commons-codec, it
130+
declares a newer commons-codec than the one declared by httpclient. -->
131+
<groupId>commons-codec</groupId>
132+
<artifactId>commons-codec</artifactId>
133+
</dependency>
120134
<dependency>
121135
<groupId>com.google.oauth-client</groupId>
122136
<artifactId>google-oauth-client</artifactId>

0 commit comments

Comments
 (0)