Skip to content

Commit b43acd9

Browse files
authored
[ci] Run cargo-semver-checks on most targets (#1523)
Credit to @memark for landing obi1kenobi/cargo-semver-checks-action#82, which unblocked this! Per #1565, we do not run on wasm32-wasi yet. Closes #357
1 parent 2cba5ac commit b43acd9

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

.github/workflows/ci.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -330,11 +330,6 @@ jobs:
330330
# crates.io. We do this in the matrix rather than in its own job so that it
331331
# gets run on different targets. Some of our API is target-specific (e.g.,
332332
# SIMD type impls), and so we need to run on each target.
333-
#
334-
# TODO(https://github.com/obi1kenobi/cargo-semver-checks-action/issues/54):
335-
# Currently we don't actually do anything with `matrix.target`, so we're
336-
# just duplicating work by running this job multiple times, each time
337-
# targetting the host platform.
338333
- name: Check semver compatibility
339334
uses: obi1kenobi/cargo-semver-checks-action@7272cc2caa468d3e009a2b0a9cc366839348237b # v2.6
340335
with:
@@ -353,7 +348,14 @@ jobs:
353348
feature-group: only-explicit-features
354349
features: __internal_use_only_features_that_work_on_stable
355350
rust-toolchain: ${{ env.ZC_TOOLCHAIN }}
356-
if: matrix.crate == 'zerocopy' && matrix.features == '--features __internal_use_only_features_that_work_on_stable' && matrix.toolchain == 'stable'
351+
rust-target: ${{ matrix.target }}
352+
# TODO(#1565): Run on wasm32-wasi. As of this writing, this target fails:
353+
# https://github.com/google/zerocopy/actions/runs/9944220377/job/27469879712
354+
if: |
355+
matrix.crate == 'zerocopy' &&
356+
matrix.features == '--features __internal_use_only_features_that_work_on_stable' &&
357+
matrix.toolchain == 'stable' &&
358+
matrix.target != 'wasm32-wasi'
357359
358360
# TODO(#453): Doing this as a matrix step is a hack that allows us to depend
359361
# on the fact that toolchains have already been installed. We currently only

0 commit comments

Comments
 (0)