Skip to content

Commit 1164ea6

Browse files
committed
getJvmName: clean up
1 parent 2bd017e commit 1164ea6

File tree

2 files changed

+0
-28
lines changed

2 files changed

+0
-28
lines changed

kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/ResolverAAImpl.kt

-27
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,11 @@ import org.jetbrains.kotlin.analysis.low.level.api.fir.api.getFirResolveSession
6060
import org.jetbrains.kotlin.analysis.project.structure.KtSourceModule
6161
import org.jetbrains.kotlin.asJava.classes.KtLightClassForFacade
6262
import org.jetbrains.kotlin.asJava.findFacadeClass
63-
import org.jetbrains.kotlin.asJava.toLightClass
6463
import org.jetbrains.kotlin.builtins.jvm.JavaToKotlinClassMap
6564
import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCliJavaFileManagerImpl
6665
import org.jetbrains.kotlin.fir.symbols.impl.FirCallableSymbol
6766
import org.jetbrains.kotlin.fir.types.isRaw
6867
import org.jetbrains.kotlin.fir.types.typeContext
69-
import org.jetbrains.kotlin.light.classes.symbol.methods.SymbolLightAccessorMethod
70-
import org.jetbrains.kotlin.light.classes.symbol.methods.SymbolLightSimpleMethod
7168
import org.jetbrains.kotlin.load.java.structure.impl.JavaClassImpl
7269
import org.jetbrains.kotlin.load.kotlin.JvmPackagePartSource
7370
import org.jetbrains.kotlin.load.kotlin.TypeMappingMode
@@ -77,7 +74,6 @@ import org.jetbrains.kotlin.name.ClassId
7774
import org.jetbrains.kotlin.name.FqName
7875
import org.jetbrains.kotlin.name.FqNameUnsafe
7976
import org.jetbrains.kotlin.name.Name
80-
import org.jetbrains.kotlin.psi.KtClassOrObject
8177
import org.jetbrains.kotlin.psi.KtFile
8278
import org.jetbrains.org.objectweb.asm.Opcodes
8379

@@ -487,21 +483,6 @@ class ResolverAAImpl(
487483

488484
// TODO: handle library symbols
489485
override fun getJvmName(accessor: KSPropertyAccessor): String? {
490-
(
491-
(accessor.receiver.closestClassDeclaration() as? KSClassDeclarationImpl)
492-
?.ktClassOrObjectSymbol?.psi as? KtClassOrObject
493-
)?.toLightClass()?.allMethods
494-
?.let {
495-
// If there are light accessors, information in light accessors are more accurate.
496-
// check light accessor first, if not found then default to light simple method.
497-
it.filterIsInstance<SymbolLightAccessorMethod>() + it.filterIsInstance<SymbolLightSimpleMethod>()
498-
}
499-
?.firstOrNull {
500-
(it.parameters.isNotEmpty() xor (accessor is KSPropertyGetter)) &&
501-
it.kotlinOrigin == (accessor.receiver as? KSPropertyDeclarationImpl)?.ktPropertySymbol?.psi
502-
}?.let {
503-
return it.name
504-
}
505486
if (accessor.receiver.closestClassDeclaration()?.classKind == ClassKind.ANNOTATION_CLASS) {
506487
return accessor.receiver.simpleName.asString()
507488
}
@@ -528,14 +509,6 @@ class ResolverAAImpl(
528509

529510
// TODO: handle library symbols
530511
override fun getJvmName(declaration: KSFunctionDeclaration): String? {
531-
(declaration.closestClassDeclaration() as? KSClassDeclarationImpl)?.ktDeclarationSymbol?.psi?.let {
532-
(it as? KtClassOrObject)?.toLightClass()
533-
}?.allMethods?.filterIsInstance<SymbolLightSimpleMethod>()?.singleOrNull {
534-
it.kotlinOrigin == (declaration as KSFunctionDeclarationImpl).ktFunctionSymbol.psi
535-
}?.let {
536-
return it.name
537-
}
538-
539512
val symbol: KaFunctionSymbol? = when (declaration) {
540513
is KSFunctionDeclarationImpl -> declaration.ktFunctionSymbol
541514
else -> null

kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/util.kt

-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ import org.jetbrains.kotlin.analysis.api.impl.base.types.KaBaseStarTypeProjectio
5151
import org.jetbrains.kotlin.analysis.api.impl.base.types.KaBaseTypeArgumentWithVariance
5252
import org.jetbrains.kotlin.analysis.api.platform.lifetime.KotlinAlwaysAccessibleLifetimeToken
5353
import org.jetbrains.kotlin.analysis.api.projectStructure.KaLibraryModule
54-
import org.jetbrains.kotlin.analysis.api.projectStructure.KaLibrarySourceModule
5554
import org.jetbrains.kotlin.analysis.api.projectStructure.KaSourceModule
5655
import org.jetbrains.kotlin.analysis.api.symbols.*
5756
import org.jetbrains.kotlin.analysis.api.symbols.markers.KaDeclarationContainerSymbol

0 commit comments

Comments
 (0)