Skip to content

Commit 08728e4

Browse files
cpovirkGoogle Java Core Libraries
authored and
Google Java Core Libraries
committed
Upgrade to a version of plexus-io from after a performance improvement was restored.
(See codehaus-plexus/plexus-io#109.) This CL _shouldn't_ make a performance difference because cl/650419894 _should_ have moved us to a version before the performance improvement was originally reverted. However, I messed that prior CL up, pinning us to the slow 3.4.1 instead of the fast 3.3.1. So in fact this CL _does_ improve performance back to the point it was at for 3.3.1. Today, that means an improvement from ~75s to ~1s for a clean `mvn source:jar-no-fork -f guava` on our Google workstations. RELNOTES=n/a PiperOrigin-RevId: 686480922
1 parent 0a29129 commit 08728e4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

android/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,8 @@
263263
<dependency>
264264
<groupId>org.codehaus.plexus</groupId>
265265
<artifactId>plexus-io</artifactId>
266-
<!-- DO NOT UPGRADE this past 3.4.1 until https://github.com/codehaus-plexus/plexus-io/issues/109 is fixed (probably in 3.5.1). -->
267-
<version>3.4.1</version>
266+
<!-- We need at least 3.5.1 to avoid https://github.com/codehaus-plexus/plexus-io/issues/109. Once we upgrade maven-source-plugin itself to a version new enough to depend on 3.5.1 or higher, we can remove this override. -->
267+
<version>3.5.1</version>
268268
</dependency>
269269
</dependencies>
270270
</plugin>

pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,8 @@
264264
<dependency>
265265
<groupId>org.codehaus.plexus</groupId>
266266
<artifactId>plexus-io</artifactId>
267-
<!-- DO NOT UPGRADE this past 3.4.1 until https://github.com/codehaus-plexus/plexus-io/issues/109 is fixed (probably in 3.5.1). -->
268-
<version>3.4.1</version>
267+
<!-- We need at least 3.5.1 to avoid https://github.com/codehaus-plexus/plexus-io/issues/109. Once we upgrade maven-source-plugin itself to a version new enough to depend on 3.5.1 or higher, we can remove this override. -->
268+
<version>3.5.1</version>
269269
</dependency>
270270
</dependencies>
271271
</plugin>

0 commit comments

Comments
 (0)