Skip to content

Commit 78caa5e

Browse files
authored
Improve Maven plugin configuration (#2775)
- Explicitly specifies `org.apache.maven.plugins` group ID - Removes redundant `maven-failsafe-plugin` version in `test-shrinker` module This is inherited from the parent POM - Adds required Error Prone compiler arg, see https://github.com/google/error-prone/releases/tag/v2.34.0
1 parent 04f66f9 commit 78caa5e

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

gson/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@
257257
</configuration>
258258
</plugin>
259259
<plugin>
260+
<groupId>org.apache.maven.plugins</groupId>
260261
<artifactId>maven-resources-plugin</artifactId>
261262
<version>3.3.1</version>
262263
<executions>

pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,7 @@
228228
<compilerArgs>
229229
<!-- Args related to Error Prone, see: https://errorprone.info/docs/installation#maven -->
230230
<arg>-XDcompilePolicy=simple</arg>
231+
<arg>--should-stop=ifError=FLOW</arg>
231232
<arg>-Xplugin:ErrorProne
232233
-XepExcludedPaths:.*/generated-test-sources/protobuf/.*
233234
-Xep:NotJavadoc:OFF <!-- Triggered by local class. -->
@@ -403,6 +404,7 @@
403404
</configuration>
404405
</plugin>
405406
<plugin>
407+
<groupId>org.apache.maven.plugins</groupId>
406408
<artifactId>maven-antrun-plugin</artifactId>
407409
<version>3.1.0</version>
408410
<executions>

test-shrinker/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,6 @@
198198
<plugin>
199199
<groupId>org.apache.maven.plugins</groupId>
200200
<artifactId>maven-failsafe-plugin</artifactId>
201-
<version>3.5.1</version>
202201
<executions>
203202
<execution>
204203
<goals>

0 commit comments

Comments
 (0)