Skip to content

Commit 94aff6b

Browse files
ashish1294kevinb9n
authored and
kevinb9n
committed
Exclusion of graphVerify() chain from return ignore value check must be done in AbstractReturnValueIgnored class - since both FutureReturnValueIgnored and CheckReturnValue checker needs to ignore graphVerify chain.
GraphWrapper's start() method returns a Future and is also explicitly marked with @CheckReturnValue : [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=313420781
1 parent 5bb7089 commit 94aff6b

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

core/src/main/java/com/google/errorprone/bugpatterns/AbstractReturnValueIgnored.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,4 +259,5 @@ static boolean mockitoInvocation(Tree tree, VisitorState state) {
259259
ExpressionTree receiver = ASTHelpers.getReceiver(invocation);
260260
return MOCKITO_MATCHER.matches(receiver, state);
261261
}
262+
262263
}

core/src/test/java/com/google/errorprone/bugpatterns/CheckReturnValueTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -643,4 +643,5 @@ public void noCRVonClasspath() {
643643
.withClasspath(CRVTest.class, CheckReturnValueTest.class)
644644
.doTest();
645645
}
646+
646647
}

0 commit comments

Comments
 (0)