Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Commit 650da25

Browse files
authored
cleanup: use built-in release-please types (#900)
In 16.4.0, we correctly export CreateRelease and PullRequest which are types returned by Manifest.
1 parent 6908db2 commit 650da25

File tree

1 file changed

+1
-29
lines changed

1 file changed

+1
-29
lines changed

src/index.ts

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
// limitations under the License.
1414

1515
import * as core from '@actions/core';
16-
import {GitHub, Manifest} from 'release-please';
16+
import {GitHub, Manifest, CreatedRelease, PullRequest} from 'release-please';
1717

1818
const DEFAULT_CONFIG_FILE = 'release-please-config.json';
1919
const DEFAULT_MANIFEST_FILE = '.release-please-manifest.json';
@@ -42,34 +42,6 @@ interface ActionInputs {
4242
includeComponentInTag?: boolean;
4343
}
4444

45-
// TODO: replace this interface is exported from release-please
46-
interface PullRequest {
47-
readonly headBranchName: string;
48-
readonly baseBranchName: string;
49-
readonly number: number;
50-
readonly title: string;
51-
readonly body: string;
52-
readonly labels: string[];
53-
readonly files: string[];
54-
readonly sha?: string;
55-
}
56-
// TODO: replace this interface is exported from release-please
57-
interface CreatedRelease {
58-
id: number;
59-
path: string;
60-
version: string;
61-
major: number;
62-
minor: number;
63-
patch: number;
64-
name?: string;
65-
tagName: string;
66-
sha: string;
67-
notes?: string;
68-
url: string;
69-
draft?: boolean;
70-
uploadUrl?: string;
71-
}
72-
7345
function parseInputs(): ActionInputs {
7446
const inputs: ActionInputs = {
7547
token: core.getInput('token', {required: true}),

0 commit comments

Comments
 (0)