-
Notifications
You must be signed in to change notification settings - Fork 306
Added support for callbacks on streamed response #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added support for callbacks on streamed response #410
Conversation
causing test problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! This change has already been proposed in [Original PR #371]. Submitting duplicate PRs doesn’t add value and can create unnecessary noise for maintainers. It’s best to check existing PRs before submitting new ones. Maybe consider contributing in other meaningful ways!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sevenhealer, package.json has been modified, but there’s no apparent need for this change. Could you clarify why this was updated? If it's unintentional, please revert it to avoid unnecessary changes in dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix Cannot read .eslintignore file #399
I mentioned here.
for windows during npm run test <- it failed
so using cross-env solve this issue for all env(windows,linux and mac)
The test case of the PR you mentioned failed. |
The failure in Original PR #371 is due to a Contributor License Agreement (CLA) check, not a test case failure. This means the contributor must sign the CLA before the PR can proceed. Submitting duplicate PRs doesn't resolve this issue and can create unnecessary work for maintainers. It's best to resolve the CLA issue in the original PR. If the issue isn't addressed in a reasonable time, then raising a new PR would be appropriate. Thanks, and happy contributing! |
Add streamCallbacks as an Optional Argument to generateContentStream for Easier Handling of Responses. Fixes #322
Check:
Create a js file
nano test.js
Output:
onData

onEnd:

Also Fixed .gitignore to Prevent Unnecessary Upload of package-lock.json