dev: simplify cutVal implementation #5206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A character can use several runes so you cannot do that. |
Does this mean that the |
No, it means that a test is validating only the cases defined inside the tests. The current implementation of In fact, the current implementation and your proposal have the same limitations, so we can accept your PR. For the details, emoji ZWJ sequences are not handled correctly, so a composite emoji can be cut improperly, but I think this is a minor edge case. |
ldez
added
topic: cosmetic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR refactors the implementation of an unexported function
cutValin theprinterspackage.