From 80ddf59b71ba00c8c06f5ef2384033357318e3dc Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 4 Jan 2021 05:42:14 +0000 Subject: [PATCH 01/24] build(deps): bump github.com/kulti/thelper from 0.1.0 to 0.2.0 Bumps [github.com/kulti/thelper](https://github.com/kulti/thelper) from 0.1.0 to 0.2.0. - [Release notes](https://github.com/kulti/thelper/releases) - [Changelog](https://github.com/kulti/thelper/blob/master/.goreleaser.yml) - [Commits](https://github.com/kulti/thelper/compare/v0.1.0...v0.2.0) Signed-off-by: dependabot[bot] --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index b8b5ae9c19f7..3fadb07af920 100644 --- a/go.mod +++ b/go.mod @@ -31,7 +31,7 @@ require ( github.com/jgautheron/goconst v0.0.0-20201117150253-ccae5bf973f3 github.com/jingyugao/rowserrcheck v0.0.0-20191204022205-72ab7603b68a github.com/jirfag/go-printf-func-name v0.0.0-20191110105641-45db9963cdd3 - github.com/kulti/thelper v0.1.0 + github.com/kulti/thelper v0.2.0 github.com/kunwardeep/paralleltest v1.0.2 github.com/kyoh86/exportloopref v0.1.8 github.com/maratori/testpackage v1.0.1 diff --git a/go.sum b/go.sum index 0603a79a49f5..736809e07713 100644 --- a/go.sum +++ b/go.sum @@ -232,8 +232,8 @@ github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ= github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI= github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY= github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE= -github.com/kulti/thelper v0.1.0 h1:ig1EW6yhDiRNN3dplbhdsW2gTvbxTz9i4q5Rr/tRfpk= -github.com/kulti/thelper v0.1.0/go.mod h1:vMu2Cizjy/grP+jmsvOFDx1kYP6+PD1lqg4Yu5exl2U= +github.com/kulti/thelper v0.2.0 h1:0hWMFWREtbyuGTPl/d2c1Kq/VfzNM97NzRwp1zMLaAc= +github.com/kulti/thelper v0.2.0/go.mod h1:vMu2Cizjy/grP+jmsvOFDx1kYP6+PD1lqg4Yu5exl2U= github.com/kunwardeep/paralleltest v1.0.2 h1:/jJRv0TiqPoEy/Y8dQxCFJhD56uS/pnvtatgTZBHokU= github.com/kunwardeep/paralleltest v1.0.2/go.mod h1:ZPqNm1fVHPllh5LPVujzbVz1JN2GhLxSfY+oqUsvG30= github.com/kyoh86/exportloopref v0.1.8 h1:5Ry/at+eFdkX9Vsdw3qU4YkvGtzuVfzT4X7S77LoN/M= From 9d8c38829a94069956b67ee567d88783e747f023 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Mon, 4 Jan 2021 19:17:02 +0100 Subject: [PATCH 02/24] TEMP --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index be1fc0d8cc09..81e07cdd99f7 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -32,7 +32,7 @@ jobs: - name: lint uses: golangci/golangci-lint-action@v2.3.0 with: - version: latest + version: v1.34.0 tests-on-windows: needs: golangci-lint # run after golangci-lint action to not produce duplicated errors runs-on: windows-latest From e0539934214436cc79812457a5aef9c2423945e4 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Mon, 4 Jan 2021 19:36:51 +0100 Subject: [PATCH 03/24] TEMP --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 81e07cdd99f7..a43c13e654b7 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -32,7 +32,7 @@ jobs: - name: lint uses: golangci/golangci-lint-action@v2.3.0 with: - version: v1.34.0 + version: v1.34.1 tests-on-windows: needs: golangci-lint # run after golangci-lint action to not produce duplicated errors runs-on: windows-latest From 5f8a76365acec563c75f91eabfb1f98dde70fdec Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Mon, 4 Jan 2021 21:37:15 +0100 Subject: [PATCH 04/24] TEMP --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index a43c13e654b7..056262ccc302 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -32,7 +32,7 @@ jobs: - name: lint uses: golangci/golangci-lint-action@v2.3.0 with: - version: v1.34.1 + version: v1.33.2 tests-on-windows: needs: golangci-lint # run after golangci-lint action to not produce duplicated errors runs-on: windows-latest From 1939bc51d348fbbf5b32a5ce4519cbc0f9cf5646 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Mon, 4 Jan 2021 21:57:06 +0100 Subject: [PATCH 05/24] TEMP --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 056262ccc302..81e07cdd99f7 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -32,7 +32,7 @@ jobs: - name: lint uses: golangci/golangci-lint-action@v2.3.0 with: - version: v1.33.2 + version: v1.34.0 tests-on-windows: needs: golangci-lint # run after golangci-lint action to not produce duplicated errors runs-on: windows-latest From 2f298e55fac7664803c98328d7e82cb6d1e64781 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Mon, 4 Jan 2021 23:32:43 +0100 Subject: [PATCH 06/24] TEMP --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 81e07cdd99f7..be1fc0d8cc09 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -32,7 +32,7 @@ jobs: - name: lint uses: golangci/golangci-lint-action@v2.3.0 with: - version: v1.34.0 + version: latest tests-on-windows: needs: golangci-lint # run after golangci-lint action to not produce duplicated errors runs-on: windows-latest From e2203367d69fe6c163b1ed2354ab0d12069fc0a7 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 00:03:54 +0100 Subject: [PATCH 07/24] TEMP --- pkg/golinters/scopelint.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/golinters/scopelint.go b/pkg/golinters/scopelint.go index 258912e0b774..19c24bd39367 100644 --- a/pkg/golinters/scopelint.go +++ b/pkg/golinters/scopelint.go @@ -165,8 +165,7 @@ func (f *Node) Visit(node ast.Node) ast.Visitor { // It returns the new Problem. //nolint:interfacer func (f *Node) errorf(n ast.Node, format string, args ...interface{}) { - pos := f.fset.Position(n.Pos()) - f.errorAtf(pos, format, args...) + f.errorAtf(f.fset.Position(n.Pos()), format, args...) } func (f *Node) errorAtf(pos token.Position, format string, args ...interface{}) { From 06c5115492ef6b26da1709d92402696637db7bbc Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 00:07:30 +0100 Subject: [PATCH 08/24] TEMP --- pkg/golinters/scopelint.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/golinters/scopelint.go b/pkg/golinters/scopelint.go index 19c24bd39367..be9b699fc81d 100644 --- a/pkg/golinters/scopelint.go +++ b/pkg/golinters/scopelint.go @@ -163,9 +163,10 @@ func (f *Node) Visit(node ast.Node) ast.Visitor { // The variadic arguments may start with link and category types, // and must end with a format string and any arguments. // It returns the new Problem. -//nolint:interfacer +//nolint:interfacer,dupl func (f *Node) errorf(n ast.Node, format string, args ...interface{}) { - f.errorAtf(f.fset.Position(n.Pos()), format, args...) + pos := f.fset.Position(n.Pos()) + f.errorAtf(pos, format, args...) } func (f *Node) errorAtf(pos token.Position, format string, args ...interface{}) { From cf6d107c351c9b602034c779d2309a0c38540dbb Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 00:10:03 +0100 Subject: [PATCH 09/24] TEMP --- pkg/golinters/scopelint.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/golinters/scopelint.go b/pkg/golinters/scopelint.go index be9b699fc81d..258912e0b774 100644 --- a/pkg/golinters/scopelint.go +++ b/pkg/golinters/scopelint.go @@ -163,7 +163,7 @@ func (f *Node) Visit(node ast.Node) ast.Visitor { // The variadic arguments may start with link and category types, // and must end with a format string and any arguments. // It returns the new Problem. -//nolint:interfacer,dupl +//nolint:interfacer func (f *Node) errorf(n ast.Node, format string, args ...interface{}) { pos := f.fset.Position(n.Pos()) f.errorAtf(pos, format, args...) From c0daf4da66ffabe5ac541b695d8d18636186d891 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 00:17:49 +0100 Subject: [PATCH 10/24] TEMP --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index be1fc0d8cc09..6e0595409f3e 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -30,7 +30,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: lint - uses: golangci/golangci-lint-action@v2.3.0 + uses: golangci/golangci-lint-action@v2.2.1 with: version: latest tests-on-windows: From 3b7e1d0c768adc597a090a806fc7a8c84195d537 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 01:33:52 +0100 Subject: [PATCH 11/24] TEMP --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 6e0595409f3e..be1fc0d8cc09 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -30,7 +30,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: lint - uses: golangci/golangci-lint-action@v2.2.1 + uses: golangci/golangci-lint-action@v2.3.0 with: version: latest tests-on-windows: From 10776ae29076289da23aed75da8ac44b9fa4a1ad Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 02:10:49 +0100 Subject: [PATCH 12/24] TEMP --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index be1fc0d8cc09..11ea05a4758d 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -26,7 +26,7 @@ jobs: # We already run the current golangci-lint in tests, but here we test # our GitHub action with the latest stable golangci-lint. golangci-lint: - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v2 - name: lint From 0cc58dc216c8491e80844aa9f9f6b343c51f4210 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 03:30:48 +0100 Subject: [PATCH 13/24] TEMP --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 11ea05a4758d..d64dc6fff45d 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -26,7 +26,7 @@ jobs: # We already run the current golangci-lint in tests, but here we test # our GitHub action with the latest stable golangci-lint. golangci-lint: - runs-on: ubuntu-20.04 + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v2 - name: lint From 47c6122345667610c3b45b182d6bb644b2024c29 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 03:34:54 +0100 Subject: [PATCH 14/24] TEMP --- .github/workflows/pr.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index d64dc6fff45d..3d5ccf98d3f7 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -26,7 +26,8 @@ jobs: # We already run the current golangci-lint in tests, but here we test # our GitHub action with the latest stable golangci-lint. golangci-lint: - runs-on: ubuntu-18.04 + needs: go-mod + runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: lint From 9004d887118402d2285a855bdb64e2aa5ade5ac1 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 03:55:23 +0100 Subject: [PATCH 15/24] TEMP --- .github/workflows/pr.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 3d5ccf98d3f7..897603d8de11 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -15,7 +15,7 @@ jobs: - name: Install Go uses: actions/setup-go@v2 with: - go-version: 1.15 + go-version: 1.15.4 - name: Checkout code uses: actions/checkout@v2 - name: Check go mod @@ -26,7 +26,6 @@ jobs: # We already run the current golangci-lint in tests, but here we test # our GitHub action with the latest stable golangci-lint. golangci-lint: - needs: go-mod runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From 47f706976c631eb97e4931032e6b821a64b305e6 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 03:58:06 +0100 Subject: [PATCH 16/24] TEMP --- .github/workflows/pr.yml | 2 +- .golangci.yml | 3 +++ pkg/golinters/scopelint.go | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 897603d8de11..be1fc0d8cc09 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -15,7 +15,7 @@ jobs: - name: Install Go uses: actions/setup-go@v2 with: - go-version: 1.15.4 + go-version: 1.15 - name: Checkout code uses: actions/checkout@v2 - name: Check go mod diff --git a/.golangci.yml b/.golangci.yml index 012255c281b4..15d45e021203 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -131,6 +131,9 @@ issues: - gocritic text: "unnecessaryDefer:" + - path: pkg/golinters/scopelint.go + text: "directive `//nolint:interfacer,dupl` is unused for linter interfacer" + run: skip-dirs: - test/testdata_etc diff --git a/pkg/golinters/scopelint.go b/pkg/golinters/scopelint.go index 258912e0b774..be9b699fc81d 100644 --- a/pkg/golinters/scopelint.go +++ b/pkg/golinters/scopelint.go @@ -163,7 +163,7 @@ func (f *Node) Visit(node ast.Node) ast.Visitor { // The variadic arguments may start with link and category types, // and must end with a format string and any arguments. // It returns the new Problem. -//nolint:interfacer +//nolint:interfacer,dupl func (f *Node) errorf(n ast.Node, format string, args ...interface{}) { pos := f.fset.Position(n.Pos()) f.errorAtf(pos, format, args...) From 8b93b859b54b0a5a30a181ad919299ae237155a6 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 03:58:16 +0100 Subject: [PATCH 17/24] TEMP --- pkg/golinters/scopelint.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/golinters/scopelint.go b/pkg/golinters/scopelint.go index be9b699fc81d..258912e0b774 100644 --- a/pkg/golinters/scopelint.go +++ b/pkg/golinters/scopelint.go @@ -163,7 +163,7 @@ func (f *Node) Visit(node ast.Node) ast.Visitor { // The variadic arguments may start with link and category types, // and must end with a format string and any arguments. // It returns the new Problem. -//nolint:interfacer,dupl +//nolint:interfacer func (f *Node) errorf(n ast.Node, format string, args ...interface{}) { pos := f.fset.Position(n.Pos()) f.errorAtf(pos, format, args...) From 0d7369d6a544f2cc567370f58de00cb91a341be2 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 04:06:32 +0100 Subject: [PATCH 18/24] TEMP --- .golangci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 15d45e021203..b4f444a6e18c 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -131,8 +131,9 @@ issues: - gocritic text: "unnecessaryDefer:" + # TODO temporary rule must be removed. - path: pkg/golinters/scopelint.go - text: "directive `//nolint:interfacer,dupl` is unused for linter interfacer" + text: 'directive `//nolint:interfacer` is unused for linter interfacer' run: skip-dirs: From b6cee6204d1629913af0ffcda6484fb58dd241dc Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 04:12:20 +0100 Subject: [PATCH 19/24] TEMP --- .golangci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index b4f444a6e18c..a3e56c2a12eb 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -131,7 +131,8 @@ issues: - gocritic text: "unnecessaryDefer:" - # TODO temporary rule must be removed. + # TODO temporary rule, must be removed, seems related to v0.34.1 + # but I was not able to reproduce locally only the CI seems affected by this issue. - path: pkg/golinters/scopelint.go text: 'directive `//nolint:interfacer` is unused for linter interfacer' From 4e26b371b099fb89147749a135278658ae74d8ee Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 04:17:28 +0100 Subject: [PATCH 20/24] TEMP --- .golangci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.golangci.yml b/.golangci.yml index a3e56c2a12eb..e29f09b5475c 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -133,6 +133,7 @@ issues: # TODO temporary rule, must be removed, seems related to v0.34.1 # but I was not able to reproduce locally only the CI seems affected by this issue. + # I was also not able to reproduce in the CI of a fork. - path: pkg/golinters/scopelint.go text: 'directive `//nolint:interfacer` is unused for linter interfacer' From b0f58d7f7097b3e181eeeb167e5f518f9e7d5d8f Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 04:25:20 +0100 Subject: [PATCH 21/24] TEMP --- .golangci.yml | 4 ++-- pkg/golinters/scopelint.go | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index e29f09b5475c..f9e0eef7dd21 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -134,8 +134,8 @@ issues: # TODO temporary rule, must be removed, seems related to v0.34.1 # but I was not able to reproduce locally only the CI seems affected by this issue. # I was also not able to reproduce in the CI of a fork. - - path: pkg/golinters/scopelint.go - text: 'directive `//nolint:interfacer` is unused for linter interfacer' +# - path: pkg/golinters/scopelint.go +# text: 'directive `//nolint:interfacer` is unused for linter interfacer' run: skip-dirs: diff --git a/pkg/golinters/scopelint.go b/pkg/golinters/scopelint.go index 258912e0b774..ba3921e1964e 100644 --- a/pkg/golinters/scopelint.go +++ b/pkg/golinters/scopelint.go @@ -162,7 +162,6 @@ func (f *Node) Visit(node ast.Node) ast.Visitor { // The variadic arguments may start with link and category types, // and must end with a format string and any arguments. -// It returns the new Problem. //nolint:interfacer func (f *Node) errorf(n ast.Node, format string, args ...interface{}) { pos := f.fset.Position(n.Pos()) From f990838cd6c6cdf995af1b4fe63b101aa750681b Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 04:29:29 +0100 Subject: [PATCH 22/24] TEMP --- .golangci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index f9e0eef7dd21..e29f09b5475c 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -134,8 +134,8 @@ issues: # TODO temporary rule, must be removed, seems related to v0.34.1 # but I was not able to reproduce locally only the CI seems affected by this issue. # I was also not able to reproduce in the CI of a fork. -# - path: pkg/golinters/scopelint.go -# text: 'directive `//nolint:interfacer` is unused for linter interfacer' + - path: pkg/golinters/scopelint.go + text: 'directive `//nolint:interfacer` is unused for linter interfacer' run: skip-dirs: From 95e0104a74df1713ed62f57a604f54ee46621f8c Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 04:38:59 +0100 Subject: [PATCH 23/24] TEMP --- .golangci.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index e29f09b5475c..cf13baba96b4 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -131,9 +131,10 @@ issues: - gocritic text: "unnecessaryDefer:" - # TODO temporary rule, must be removed, seems related to v0.34.1 - # but I was not able to reproduce locally only the CI seems affected by this issue. - # I was also not able to reproduce in the CI of a fork. + # TODO temporary rule, must be removed + # seems related to v0.34.1, but I was not able to reproduce locally, + # I was also not able to reproduce in the CI of a fork, + # only the golangci-lint CI seems to affected by this invalid analysis. - path: pkg/golinters/scopelint.go text: 'directive `//nolint:interfacer` is unused for linter interfacer' From 846b72ff4fb8489f9116d4d5118a236049637531 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 5 Jan 2021 05:00:55 +0100 Subject: [PATCH 24/24] TEMP --- .golangci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index cf13baba96b4..830b3f405c3b 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -134,7 +134,7 @@ issues: # TODO temporary rule, must be removed # seems related to v0.34.1, but I was not able to reproduce locally, # I was also not able to reproduce in the CI of a fork, - # only the golangci-lint CI seems to affected by this invalid analysis. + # only the golangci-lint CI seems to be affected by this invalid analysis. - path: pkg/golinters/scopelint.go text: 'directive `//nolint:interfacer` is unused for linter interfacer'