Skip to content

Make incremental program loading #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jirfag opened this issue Jun 12, 2018 · 4 comments
Closed

Make incremental program loading #92

jirfag opened this issue Jun 12, 2018 · 4 comments
Labels
topic: speed
Milestone
v1.20.0

Comments

@jirfag
Copy link
Contributor

jirfag commented Jun 12, 2018 •
edited
Loading

Currently, it's the slowest part of golangci-lint in "slow" (without --fast) mode.
Need to cache loaded packages and reload only changed packages.
@jirfag jirfag mentioned this issue Jun 12, 2018
Closed
@tpounds tpounds added the stale No recent correspondence or work activity label Oct 1, 2019
@tpounds
Copy link
Contributor

tpounds commented Oct 1, 2019

@jirfag Is this still valid after all the recent work in #337?

@jirfag jirfag added this to the v1.20.0 milestone Oct 2, 2019
@jirfag
Copy link
Contributor Author

jirfag commented Oct 2, 2019

yes, it's valid, I'm currently doing that

@tpounds
Copy link
Contributor

tpounds commented Oct 2, 2019

Sounds good! I'll remove the stale label.

@tpounds tpounds removed the stale No recent correspondence or work activity label Oct 2, 2019
@jirfag
Copy link
Contributor Author

jirfag commented Oct 14, 2019

done in #768

@jirfag jirfag closed this as completed Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: speed
Projects
None yet
Milestone
v1.20.0
Development

No branches or pull requests
2 participants
@tpounds @jirfag